From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:52822 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726319AbeJOBGT (ORCPT ); Sun, 14 Oct 2018 21:06:19 -0400 Date: Sun, 14 Oct 2018 10:24:33 -0700 From: Christoph Hellwig Subject: Re: [PATCH 16/25] vfs: make remapping to source file eof more explicit Message-ID: <20181014172433.GG30673@infradead.org> References: <153938912912.8361.13446310416406388958.stgit@magnolia> <153938925737.8361.3995899966552253527.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <153938925737.8361.3995899966552253527.stgit@magnolia> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: "Darrick J. Wong" Cc: david@fromorbit.com, sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, Amir Goldstein , linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com On Fri, Oct 12, 2018 at 05:07:37PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Create a RFR_TO_SRC_EOF flag to explicitly declare that the caller wants > the remap implementation to remap to the end of the source file, once > the files are locked. The name looks like a cat threw up on your keyboard :) >>From reading the code this seems to ask for a whole file remap, right? Why not put that in the name to make it more descriptive?