From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfs_scrub: lack of kernel support is not a service failure
Date: Mon, 15 Oct 2018 09:03:44 -0700 [thread overview]
Message-ID: <20181015160344.GJ28243@magnolia> (raw)
From: Darrick J. Wong <darrick.wong@oracle.com>
Don't treat a lack of kernel support for scrubbing as an automated
service failure because we have not actually determined that there's
anything wrong with the filesystem.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
scrub/xfs_scrub.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scrub/xfs_scrub.c b/scrub/xfs_scrub.c
index 33b83a5f..6a0304d2 100644
--- a/scrub/xfs_scrub.c
+++ b/scrub/xfs_scrub.c
@@ -779,9 +779,15 @@ main(
* for capturing all the log messages if the scrub fails, because the
* fail service uses the service name to gather log messages for the
* error report.
+ *
+ * Note: We don't count a lack of kernel support as a service failure
+ * because we haven't determined that there's anything wrong with the
+ * filesystem.
*/
if (is_service) {
sleep(2);
+ if (!ctx.scrub_setup_succeeded)
+ return 0;
if (ret != SCRUB_RET_SUCCESS)
return 1;
}
next reply other threads:[~2018-10-15 23:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 16:03 Darrick J. Wong [this message]
2018-10-15 23:05 ` [PATCH] xfs_scrub: lack of kernel support is not a service failure Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015160344.GJ28243@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).