* [PATCH] xfs_scrub: lack of kernel support is not a service failure
@ 2018-10-15 16:03 Darrick J. Wong
2018-10-15 23:05 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2018-10-15 16:03 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs
From: Darrick J. Wong <darrick.wong@oracle.com>
Don't treat a lack of kernel support for scrubbing as an automated
service failure because we have not actually determined that there's
anything wrong with the filesystem.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
scrub/xfs_scrub.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scrub/xfs_scrub.c b/scrub/xfs_scrub.c
index 33b83a5f..6a0304d2 100644
--- a/scrub/xfs_scrub.c
+++ b/scrub/xfs_scrub.c
@@ -779,9 +779,15 @@ main(
* for capturing all the log messages if the scrub fails, because the
* fail service uses the service name to gather log messages for the
* error report.
+ *
+ * Note: We don't count a lack of kernel support as a service failure
+ * because we haven't determined that there's anything wrong with the
+ * filesystem.
*/
if (is_service) {
sleep(2);
+ if (!ctx.scrub_setup_succeeded)
+ return 0;
if (ret != SCRUB_RET_SUCCESS)
return 1;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] xfs_scrub: lack of kernel support is not a service failure
2018-10-15 16:03 [PATCH] xfs_scrub: lack of kernel support is not a service failure Darrick J. Wong
@ 2018-10-15 23:05 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2018-10-15 23:05 UTC (permalink / raw)
To: Darrick J. Wong, Eric Sandeen; +Cc: xfs
On 10/15/18 11:03 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Don't treat a lack of kernel support for scrubbing as an automated
> service failure because we have not actually determined that there's
> anything wrong with the filesystem.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
makes sense to me
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> scrub/xfs_scrub.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/scrub/xfs_scrub.c b/scrub/xfs_scrub.c
> index 33b83a5f..6a0304d2 100644
> --- a/scrub/xfs_scrub.c
> +++ b/scrub/xfs_scrub.c
> @@ -779,9 +779,15 @@ main(
> * for capturing all the log messages if the scrub fails, because the
> * fail service uses the service name to gather log messages for the
> * error report.
> + *
> + * Note: We don't count a lack of kernel support as a service failure
> + * because we haven't determined that there's anything wrong with the
> + * filesystem.
> */
> if (is_service) {
> sleep(2);
> + if (!ctx.scrub_setup_succeeded)
> + return 0;
> if (ret != SCRUB_RET_SUCCESS)
> return 1;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-16 6:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-15 16:03 [PATCH] xfs_scrub: lack of kernel support is not a service failure Darrick J. Wong
2018-10-15 23:05 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).