Re: [PATCH 2/5] xfs: factor data block addition from xfs_dir2_node_addname_int()

Dave Chinner
2018-10-26T19:29:24Z

On Fri, Oct 26, 2018 at 02:45:29AM -0700, Christoph Hellwig wrote:
> > + } else {
> > +found_block:
>
> This jumping into branch is a little ugly, but given that the next
> patch cleans it up it is probably ok.
>
> > + /* suppress gcc maybe-used-initialised warning */
> > + bests = dp->d_ops->free_bests_p(free);
>
> > - * If the freespace entry is now wrong, update it.
> > - */
> > - bests = dp->d_ops->free_bests_p(free); /* gcc is so stupid */
>
> So this moves bests from the common path of execution into the
> branch, where it duplicates one in the other branch just for later
> patches to move it back to almost where it was. If it isn't to
> painful to redo the patch I'd suggest to just keep it in the common
> path here.

Which causes build warnings because gcc can't work out the code flow
if I leave it alone. And seeing as I use -Werror on the fs/xfs/
directories, that breaks the build.

So I'd prefer to leave it like this without a transient build
warning....

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com