From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
Eric Sandeen <sandeen@redhat.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] libxfs: check all defer ops types
Date: Fri, 26 Oct 2018 12:26:51 -0700 [thread overview]
Message-ID: <20181026192651.GA16071@infradead.org> (raw)
In-Reply-To: <20181026191851.GI28243@magnolia>
On Fri, Oct 26, 2018 at 12:18:51PM -0700, Darrick J. Wong wrote:
> The downside of this is that now we have to declare all those functions
> somewhere so that the fs/xfs/ and libxfs/defer_item.c can match the
> prototypes.
I don't think that is worth the pain vs the version I posted. I don't
think removing a single indirection really buys us so much as to expose
all the internals.
next prev parent reply other threads:[~2018-10-27 4:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 16:19 [PATCH] libxfs: check all defer ops types Darrick J. Wong
2018-10-26 19:02 ` Eric Sandeen
2018-10-26 19:11 ` Eric Sandeen
2018-10-26 19:18 ` Darrick J. Wong
2018-10-26 19:26 ` Christoph Hellwig [this message]
2018-10-26 19:24 ` Christoph Hellwig
2018-10-26 19:26 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181026192651.GA16071@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox