* [PATCH] misc: only build with lto if explicitly enabled
@ 2018-10-26 23:25 Darrick J. Wong
2018-10-27 1:45 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2018-10-26 23:25 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs
From: Darrick J. Wong <darrick.wong@oracle.com>
Change the LTO default to off from probe because it wastes build time on
developer machines. Anyone who really wants it for release builds or
whatever can still turn it on.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 44a4b3a8..f8f29c07 100644
--- a/configure.ac
+++ b/configure.ac
@@ -109,8 +109,8 @@ AC_ARG_ENABLE(threadsan,
AC_SUBST(enable_threadsan)
AC_ARG_ENABLE(lto,
-[ --enable-lto=[yes/no] Enable link time optimization (LTO) [default=probe]],,
- enable_lto=probe)
+[ --enable-lto=[yes/no] Enable link time optimization (LTO) [default=no]],,
+ enable_lto=no)
AC_SUBST(enable_lto)
# Enable xfs_scrub build
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] misc: only build with lto if explicitly enabled
2018-10-26 23:25 [PATCH] misc: only build with lto if explicitly enabled Darrick J. Wong
@ 2018-10-27 1:45 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2018-10-27 1:45 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eric Sandeen, xfs
On Fri, Oct 26, 2018 at 04:25:38PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Change the LTO default to off from probe because it wastes build time on
> developer machines. Anyone who really wants it for release builds or
> whatever can still turn it on.
Build time is not the problem. Making the resultant binary
completely unusable with gdb and hence undebuggable is the real
problem with LTO.
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> configure.ac | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 44a4b3a8..f8f29c07 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -109,8 +109,8 @@ AC_ARG_ENABLE(threadsan,
> AC_SUBST(enable_threadsan)
>
> AC_ARG_ENABLE(lto,
> -[ --enable-lto=[yes/no] Enable link time optimization (LTO) [default=probe]],,
> - enable_lto=probe)
> +[ --enable-lto=[yes/no] Enable link time optimization (LTO) [default=no]],,
> + enable_lto=no)
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-27 10:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-26 23:25 [PATCH] misc: only build with lto if explicitly enabled Darrick J. Wong
2018-10-27 1:45 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox