From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:39072 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726918AbeKGGrm (ORCPT ); Wed, 7 Nov 2018 01:47:42 -0500 Date: Wed, 7 Nov 2018 08:20:28 +1100 From: Dave Chinner Subject: Re: [PATCH 1/8] xfs: count inode blocks correctly in inobt scrub Message-ID: <20181106212028.GO19305@dastard> References: <154147728649.32496.4515247239602322709.stgit@magnolia> <154147729274.32496.16585638036818485278.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <154147729274.32496.16585638036818485278.stgit@magnolia> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org On Mon, Nov 05, 2018 at 08:08:12PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > A big block filesystem might require more than one inobt record to cover > all the inodes in the block. In these cases it is not correct to round > the irec count up to the nearest block because this causes us to > overestimate the number of inode blocks we expect to find. > > Signed-off-by: Darrick J. Wong Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com