From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>,
Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: defer online discard submission to a workqueue
Date: Fri, 9 Nov 2018 07:04:12 -0800 [thread overview]
Message-ID: <20181109150412.GA9153@infradead.org> (raw)
In-Reply-To: <41f009c2-8f17-ca67-6981-72160bdc94c7@sandeen.net>
On Mon, Nov 05, 2018 at 04:20:24PM -0600, Eric Sandeen wrote:
> Is there some downside to Brian's proposal, in principle?
> It seems like it would be an improvement for device that might cause
> a discard bottleneck like this.
We create another bottleneck, we lost thottling, we don't flush
the workqueue when needed and probably a few more.
Nevermind that I don't see any point in optimizing for out of tree
code that no one even bothers to upstream. All this VDO here and there
crap from Red Hat in the last year is really more than enough.
next prev parent reply other threads:[~2018-11-10 0:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 18:10 [PATCH] xfs: defer online discard submission to a workqueue Brian Foster
2018-11-05 21:51 ` Christoph Hellwig
2018-11-05 22:20 ` Eric Sandeen
2018-11-09 15:04 ` Christoph Hellwig [this message]
2018-11-06 14:23 ` Brian Foster
2018-11-06 21:18 ` Dave Chinner
2018-11-07 13:42 ` Brian Foster
2018-11-08 0:38 ` Dave Chinner
2018-11-08 13:50 ` Brian Foster
2018-11-09 0:20 ` Dave Chinner
2018-11-09 15:23 ` Brian Foster
2018-11-09 15:06 ` Christoph Hellwig
2018-11-09 15:46 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109150412.GA9153@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).