From: Christoph Hellwig <hch@lst.de>
To: guaneryu@gmail.com
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 2/5] generic: don't assume preallocation is supported when reflinks are supported
Date: Sat, 10 Nov 2018 12:51:42 +0100 [thread overview]
Message-ID: <20181110115145.30356-3-hch@lst.de> (raw)
In-Reply-To: <20181110115145.30356-1-hch@lst.de>
Various reflink tests currently use fallocate to preallocate space without
first checking that preallocations are supported. Add explicit checks.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
tests/generic/176 | 1 +
tests/generic/372 | 1 +
tests/generic/414 | 1 +
tests/generic/415 | 1 +
tests/generic/447 | 1 +
tests/generic/515 | 1 +
6 files changed, 6 insertions(+)
diff --git a/tests/generic/176 b/tests/generic/176
index e0c0f225..a084578a 100755
--- a/tests/generic/176
+++ b/tests/generic/176
@@ -31,6 +31,7 @@ _cleanup()
_supported_os Linux
_require_scratch_reflink
_require_cp_reflink
+_require_xfs_io_command "fpunch"
_require_test_program "punch-alternating"
rm -f "$seqres.full"
diff --git a/tests/generic/372 b/tests/generic/372
index 44914453..21cf283b 100755
--- a/tests/generic/372
+++ b/tests/generic/372
@@ -31,6 +31,7 @@ _cleanup()
_supported_os Linux
_supported_fs generic
_require_scratch_reflink
+_require_xfs_io_command "falloc"
_require_xfs_io_command "fiemap"
_require_scratch_explicit_shared_extents
diff --git a/tests/generic/414 b/tests/generic/414
index 7c76d580..f9f26744 100755
--- a/tests/generic/414
+++ b/tests/generic/414
@@ -32,6 +32,7 @@ _cleanup()
_supported_os Linux
_supported_fs generic
_require_scratch_reflink
+_require_xfs_io_command "falloc"
_require_xfs_io_command "fiemap"
echo "Format and mount"
diff --git a/tests/generic/415 b/tests/generic/415
index 14fbc232..0b7554ff 100755
--- a/tests/generic/415
+++ b/tests/generic/415
@@ -34,6 +34,7 @@ _supported_fs generic
_supported_os Linux
_require_scratch_reflink
_require_cp_reflink
+_require_xfs_io_command "fpunch"
_scratch_mkfs >> $seqres.full 2>&1 || _fail "mkfs failed"
_scratch_mount || _fail "mount failed"
diff --git a/tests/generic/447 b/tests/generic/447
index 3775e49f..1e7cb3c8 100755
--- a/tests/generic/447
+++ b/tests/generic/447
@@ -32,6 +32,7 @@ _supported_os Linux
_require_scratch_reflink
_require_cp_reflink
_require_test_program "punch-alternating"
+_require_xfs_io_command "fpunch"
rm -f "$seqres.full"
diff --git a/tests/generic/515 b/tests/generic/515
index 1ae9fbfe..f9e0b3be 100755
--- a/tests/generic/515
+++ b/tests/generic/515
@@ -31,6 +31,7 @@ _cleanup()
_supported_fs generic
_supported_os Linux
_require_scratch_reflink
+_require_xfs_io_command "falloc"
rm -f $seqres.full
--
2.19.1
next prev parent reply other threads:[~2018-11-10 21:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 11:51 fstests: various fixups uncovered by the always_cow mode Christoph Hellwig
2018-11-10 11:51 ` [PATCH 1/5] generic: move prealloc-enabled fsx to separate tests Christoph Hellwig
2018-11-18 13:44 ` Eryu Guan
2018-11-19 14:20 ` Christoph Hellwig
2018-11-10 11:51 ` Christoph Hellwig [this message]
2018-11-10 11:51 ` [PATCH 3/5] xfs: don't assume preallocation is always supported on XFS Christoph Hellwig
2018-11-10 11:51 ` [PATCH 4/5] xfs: xfs_fsr requires working preallocation support Christoph Hellwig
2018-11-10 11:51 ` [PATCH 5/5] xfs/420: only check the extent layout after syncing Christoph Hellwig
2018-11-18 13:49 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181110115145.30356-3-hch@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).