From: Christoph Hellwig <hch@lst.de>
To: guaneryu@gmail.com
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 4/5] xfs: xfs_fsr requires working preallocation support
Date: Sat, 10 Nov 2018 12:51:44 +0100 [thread overview]
Message-ID: <20181110115145.30356-5-hch@lst.de> (raw)
In-Reply-To: <20181110115145.30356-1-hch@lst.de>
Check that the file system actually supports preallocation for defrag
tests that end up calling xfs_fsr, as they can't be supported in
always_cow mode.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
common/defrag | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/defrag b/common/defrag
index df249dfd..79485f0d 100644
--- a/common/defrag
+++ b/common/defrag
@@ -8,6 +8,7 @@ _require_defrag()
{
case "$FSTYP" in
xfs)
+ _require_xfs_io_command "falloc"
DEFRAG_PROG="$XFS_FSR_PROG"
;;
ext4|ext4dev)
--
2.19.1
next prev parent reply other threads:[~2018-11-10 21:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 11:51 fstests: various fixups uncovered by the always_cow mode Christoph Hellwig
2018-11-10 11:51 ` [PATCH 1/5] generic: move prealloc-enabled fsx to separate tests Christoph Hellwig
2018-11-18 13:44 ` Eryu Guan
2018-11-19 14:20 ` Christoph Hellwig
2018-11-10 11:51 ` [PATCH 2/5] generic: don't assume preallocation is supported when reflinks are supported Christoph Hellwig
2018-11-10 11:51 ` [PATCH 3/5] xfs: don't assume preallocation is always supported on XFS Christoph Hellwig
2018-11-10 11:51 ` Christoph Hellwig [this message]
2018-11-10 11:51 ` [PATCH 5/5] xfs/420: only check the extent layout after syncing Christoph Hellwig
2018-11-18 13:49 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181110115145.30356-5-hch@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).