From: Christoph Hellwig <hch@infradead.org>
To: Josef Bacik <josef@toxicpanda.com>
Cc: kernel-team@fb.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: change xfs_buf_ioapply_map to STATIC
Date: Thu, 15 Nov 2018 02:19:28 -0800 [thread overview]
Message-ID: <20181115101928.GD13913@infradead.org> (raw)
In-Reply-To: <20181107201055.25883-2-josef@toxicpanda.com>
On Wed, Nov 07, 2018 at 03:10:54PM -0500, Josef Bacik wrote:
> In order to make error injection triggering easier make
> xfs_buf_ioapply_map STATIC so it's noinline and can be kprobe'ed.
So per the whole STATIC discussion how about throwing in an explicit
noinline instead?
Then again if you really are about error injection we should probably
have a real tag here. Either explicit error injection like we have
in many places in XFS, or a trace point which should give a really
nice hook, too.
next prev parent reply other threads:[~2018-11-15 20:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 20:10 [PATCH 0/2] xfs: fix panics seen with error injection Josef Bacik
2018-11-07 20:10 ` [PATCH 1/2] xfs: change xfs_buf_ioapply_map to STATIC Josef Bacik
2018-11-15 10:19 ` Christoph Hellwig [this message]
2018-11-07 20:10 ` [PATCH 2/2] xfs: take a ref on failed bufs in xfs_inode_item_push Josef Bacik
2018-11-07 23:37 ` Dave Chinner
2018-11-07 23:43 ` Josef Bacik
2018-11-08 0:48 ` Dave Chinner
2018-11-08 1:43 ` Josef Bacik
2018-11-07 23:57 ` Josef Bacik
2018-11-08 19:36 ` Josef Bacik
2018-11-12 14:23 ` Josef Bacik
2018-11-13 5:12 ` Darrick J. Wong
2018-11-14 8:10 ` Dave Chinner
2018-11-07 22:55 ` [PATCH 0/2] xfs: fix panics seen with error injection Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115101928.GD13913@infradead.org \
--to=hch@infradead.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).