From: Christoph Hellwig <hch@lst.de>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/5] generic: move prealloc-enabled fsx to separate tests
Date: Mon, 19 Nov 2018 15:20:28 +0100 [thread overview]
Message-ID: <20181119142028.GA16619@lst.de> (raw)
In-Reply-To: <20181118134456.GC3889@desktop>
On Sun, Nov 18, 2018 at 09:44:56PM +0800, Eryu Guan wrote:
> > +#! /bin/bash
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2000-2003 Silicon Graphics, Inc. All Rights Reserved.
>
> Hmm, I think it's better to write proper Copyright information for new
> tests,
I'm not the copyright holder, so I can't easily change this. But
except for the odd All Rights reserved the above seems to be exactly
the style we use now.
> > +_cleanup()
> > +{
> > + cd /
> > + rm -rf $TEST_DIR/fsx.* $tmp.*
> > +}
>
> Use tab as indention. Please ./new to generate new test template, so all
> has been taken care of.
I can replace spaces with tabs, but I don't want to regenerate the whole
tests. In the it should stick to what we originally tested as much
as possible.
I'll look into the other changes.
next prev parent reply other threads:[~2018-11-20 0:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 11:51 fstests: various fixups uncovered by the always_cow mode Christoph Hellwig
2018-11-10 11:51 ` [PATCH 1/5] generic: move prealloc-enabled fsx to separate tests Christoph Hellwig
2018-11-18 13:44 ` Eryu Guan
2018-11-19 14:20 ` Christoph Hellwig [this message]
2018-11-10 11:51 ` [PATCH 2/5] generic: don't assume preallocation is supported when reflinks are supported Christoph Hellwig
2018-11-10 11:51 ` [PATCH 3/5] xfs: don't assume preallocation is always supported on XFS Christoph Hellwig
2018-11-10 11:51 ` [PATCH 4/5] xfs: xfs_fsr requires working preallocation support Christoph Hellwig
2018-11-10 11:51 ` [PATCH 5/5] xfs/420: only check the extent layout after syncing Christoph Hellwig
2018-11-18 13:49 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119142028.GA16619@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).