From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [RFC PATCH] xfs: flush posteof zeroing before reflink truncation
Date: Tue, 20 Nov 2018 09:07:56 +1100 [thread overview]
Message-ID: <20181119220756.GM19305@dastard> (raw)
In-Reply-To: <20181119220422.GL19305@dastard>
On Tue, Nov 20, 2018 at 09:04:22AM +1100, Dave Chinner wrote:
> On Mon, Nov 19, 2018 at 02:05:13PM -0500, Brian Foster wrote:
> > On Mon, Nov 19, 2018 at 11:26:11AM +1100, Dave Chinner wrote:
> > > (*) I've still got several different fsx variants that fail on either
> > > default configs and/or 1k block size with different signatures.
> > > Problem is they take between 370,000 ops and 5 million ops to
> > > trigger, and so generate tens to hundreds of GB of trace data....
> > >
> >
> > Have you tried 1.) further reducing the likely unrelated operations
> > (i.e., fallocs, insert/collapse range, etc.) from the test
>
> Yes. The test cases I have cut out all the unnecessary ops.
>
> Oh, look, I just found a new failure on a default 4k block size
> filesystem:
>
> # src/xfstests-dev/ltp/fsx -q -p 10000 -o 128000 -l 500000 -r 4096 -t 512 -w 512 -Z -R -W -F -H -z -C -I /mnt/scratch/foo
> 20000 clone from 0x46000 to 0x48000, (0x2000 bytes) at 0x2c000
> 100000 clone from 0x44000 to 0x51000, (0xd000 bytes) at 0x1e000
> 110000 clone from 0x54000 to 0x5b000, (0x7000 bytes) at 0xf000
> READ BAD DATA: offset = 0x1000, size = 0xb000, fname = /mnt/scratch/foo
> OFFSET GOOD BAD RANGE
> 0x07000 0xa2d9 0x711b 0x00000
> ....
And just to reinforce that these are unreliable failures, the second
time I ran the above command:
$ src/xfstests-dev/ltp/fsx -q -p 10000 -o 128000 -l 500000 -r 4096 -t 512 -w 512 -Z -R -W -F -H -z -C -I /mnt/scratch/foo
20000 clone from 0x46000 to 0x48000, (0x2000 bytes) at 0x2c000
100000 clone from 0x44000 to 0x51000, (0xd000 bytes) at 0x1e000
110000 clone from 0x54000 to 0x5b000, (0x7000 bytes) at 0xf000
120000 clone from 0x3a000 to 0x3e000, (0x4000 bytes) at 0x10000
140000 trunc from 0x62400 to 0xd800
190000 trunc from 0x56800 to 0x78e00
READ BAD DATA: offset = 0x2c000, size = 0x1c000, fname = /mnt/scratch/foo
OFFSET GOOD BAD RANGE
0x32000 0xc81d 0x9289 0x00000
.....
It failed somewhere else. That's the difficulty I'm having here -
the failures aren't reliable.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2018-11-20 8:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 19:07 [RFC PATCH] xfs: flush posteof zeroing before reflink truncation Darrick J. Wong
2018-11-16 19:31 ` Brian Foster
2018-11-16 20:37 ` Dave Chinner
2018-11-18 14:12 ` Brian Foster
2018-11-19 0:26 ` Dave Chinner
2018-11-19 19:05 ` Brian Foster
2018-11-19 22:04 ` Dave Chinner
2018-11-19 22:07 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119220756.GM19305@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox