From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:35040 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729726AbeK0UNW (ORCPT ); Tue, 27 Nov 2018 15:13:22 -0500 Received: by mail-wr1-f67.google.com with SMTP id 96so21860963wrb.2 for ; Tue, 27 Nov 2018 01:16:06 -0800 (PST) Date: Tue, 27 Nov 2018 10:16:02 +0100 From: Carlos Maiolino Subject: Re: [PATCH V2] xfs: libxfs: move xfs_perag_put late Message-ID: <20181127091602.eaeczahefobpx544@hades.usersys.redhat.com> References: <1543278818-117362-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1543278818-117362-1-git-send-email-bianpan2016@163.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Pan Bian Cc: "Darrick J. Wong" , Brian Foster , Dave Chinner , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Nov 27, 2018 at 08:33:38AM +0800, Pan Bian wrote: > The function xfs_alloc_get_freelist calls xfs_perag_put to drop the > reference. However, pag->pagf_btreeblks is read and write after the > put operation. This patch moves the put operation late. I'm not a native English speaker too, but I believe it should be "is read and written after..." But, for the code itself, you can add: Reviewed-by: Carlos Maiolino Cheers > > Signed-off-by: Pan Bian > --- > V2: correct the commit log > --- > fs/xfs/libxfs/xfs_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c > index e1c0c0d..4be387d 100644 > --- a/fs/xfs/libxfs/xfs_alloc.c > +++ b/fs/xfs/libxfs/xfs_alloc.c > @@ -2435,7 +2435,6 @@ xfs_alloc_get_freelist( > be32_add_cpu(&agf->agf_flcount, -1); > xfs_trans_agflist_delta(tp, -1); > pag->pagf_flcount--; > - xfs_perag_put(pag); > > logflags = XFS_AGF_FLFIRST | XFS_AGF_FLCOUNT; > if (btreeblk) { > @@ -2443,6 +2442,7 @@ xfs_alloc_get_freelist( > pag->pagf_btreeblks++; > logflags |= XFS_AGF_BTREEBLKS; > } > + xfs_perag_put(pag); > > xfs_alloc_log_agf(tp, agbp, logflags); > *bnop = bno; > -- > 2.7.4 > > -- Carlos