From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfsprogs: don't install xfs_scrub man pages if config'd off
Date: Wed, 28 Nov 2018 08:12:48 -0800 [thread overview]
Message-ID: <20181128161248.GH8125@magnolia> (raw)
In-Reply-To: <0ba2607c-9954-94fc-fcf0-c6fe8579a2c8@redhat.com>
On Tue, Nov 27, 2018 at 01:41:31PM -0600, Eric Sandeen wrote:
> Don't install man pages for xfs_scrub if it's turned off
> in the config.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/man/man8/Makefile b/man/man8/Makefile
> index 36620da..e6a5572 100644
> --- a/man/man8/Makefile
> +++ b/man/man8/Makefile
> @@ -7,7 +7,11 @@ include $(TOPDIR)/include/builddefs
>
> MAN_SECTION = 8
>
> -MAN_PAGES = $(shell echo *.$(MAN_SECTION))
> +ifneq ("$(ENABLE_SCRUB)","yes")
> + MAN_PAGES = $(filter-out xfs_scrub%,$(shell echo *.$(MAN_SECTION)))
> +else
> + MAN_PAGES = $(shell echo *.$(MAN_SECTION))
> +endif
> MAN_DEST = $(PKG_MAN_DIR)/man$(MAN_SECTION)
> LSRCFILES = $(MAN_PAGES)
>
>
prev parent reply other threads:[~2018-11-29 3:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 19:41 [PATCH] xfsprogs: don't install xfs_scrub man pages if config'd off Eric Sandeen
2018-11-28 16:12 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128161248.GH8125@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox