From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org, tom.leiming@gmail.com,
vkuznets@redhat.com
Subject: Re: [PATCH] xfs: use a dedicated SLAB cache for sector sized buffer data
Date: Wed, 5 Dec 2018 14:35:23 -0800 [thread overview]
Message-ID: <20181205223523.GM24487@magnolia> (raw)
In-Reply-To: <20181205223346.GA5145@lst.de>
On Wed, Dec 05, 2018 at 11:33:46PM +0100, Christoph Hellwig wrote:
> On Thu, Dec 06, 2018 at 09:31:39AM +1100, Dave Chinner wrote:
> > >
> > > That's fine because log recovery is one I/O at a time, and we always
> > > free the current buffer before allocating the next one, so we'd waste
> > > the memory one way or another.
> >
> > True. Can you mention this in the commit message so it gets recorded
> > with the change and doesn't get lost in the mists of time?
>
> How about a comment instead of the commit message? Either way I can
> document this decision for v2.
A comment would be very welcome.
--D
next prev parent reply other threads:[~2018-12-05 22:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 17:20 [PATCH] xfs: use a dedicated SLAB cache for sector sized buffer data Christoph Hellwig
2018-12-05 21:50 ` Dave Chinner
2018-12-05 21:56 ` Christoph Hellwig
2018-12-05 22:31 ` Dave Chinner
2018-12-05 22:33 ` Christoph Hellwig
2018-12-05 22:35 ` Darrick J. Wong [this message]
2018-12-05 22:51 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205223523.GM24487@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=tom.leiming@gmail.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox