public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-xfs@vger.kernel.org, tom.leiming@gmail.com,
	vkuznets@redhat.com
Subject: Re: [PATCH v2] xfs: use a dedicated SLAB cache for sector sized buffer data
Date: Thu, 6 Dec 2018 21:11:06 +0100	[thread overview]
Message-ID: <20181206201105.GB31797@lst.de> (raw)
In-Reply-To: <20181206181139.GP24487@magnolia>

On Thu, Dec 06, 2018 at 10:11:39AM -0800, Darrick J. Wong wrote:
> I think this has the same problem that Dave complained about back in
> October -- if I have a hard disk with 512b sectors, a xfs with 4k
> blocks, and mount it on a machine with 64k pages, then single-sector
> buffers will get a small slab allocation, but single-fsb buffers will
> now fall back to grabbing a 64k page to hold 4k worth of data.
> 
> Even if we add a second slab for single-fsb blocks, we'll run into the
> same problem if the filesystem contains multi-block directory blocks, so
> then we'd potentially need a third slab, and... is there a way to ask a
> slab allocator for multiple contiguous objects totalling less than
> PAGE_SIZE bytes?

No, unfortunately there is not.  And the sad part is that generally it
will give you aligned ones, just with slub debugging turned on it won't.

  reply	other threads:[~2018-12-06 20:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05 22:51 [PATCH v2] xfs: use a dedicated SLAB cache for sector sized buffer data Christoph Hellwig
2018-12-06  0:59 ` Dave Chinner
2018-12-06 12:51 ` Brian Foster
2018-12-06 15:17   ` Christoph Hellwig
2018-12-06 18:00     ` Darrick J. Wong
2018-12-06 21:38   ` Dave Chinner
2018-12-06 17:22 ` Nikolay Borisov
2018-12-06 18:11 ` Darrick J. Wong
2018-12-06 20:11   ` Christoph Hellwig [this message]
2018-12-06 20:26     ` Darrick J. Wong
2018-12-06 20:39       ` Brian Foster
2018-12-06 21:33     ` Dave Chinner
2018-12-07 10:14     ` Ming Lei
2018-12-07 15:21 ` Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181206201105.GB31797@lst.de \
    --to=hch@lst.de \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=tom.leiming@gmail.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox