From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2120.oracle.com ([156.151.31.85]:51728 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727892AbeLRSfZ (ORCPT ); Tue, 18 Dec 2018 13:35:25 -0500 Date: Tue, 18 Dec 2018 10:35:21 -0800 From: "Darrick J. Wong" Subject: Re: [PATCH 4/6] xfs: move XFS_INODE_FORMAT_STR mappings to libxfs Message-ID: <20181218183521.GC27208@magnolia> References: <154344773243.4341.5458822684407979916.stgit@magnolia> <154344775711.4341.699323732443443292.stgit@magnolia> <541758f7-3af9-1eb5-db21-a0c8de9a808f@sandeen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <541758f7-3af9-1eb5-db21-a0c8de9a808f@sandeen.net> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eric Sandeen Cc: linux-xfs@vger.kernel.org On Tue, Dec 18, 2018 at 11:25:41AM -0600, Eric Sandeen wrote: > On 11/28/18 5:29 PM, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > Move XFS_INODE_FORMAT_STR to libxfs so that we don't forget to keep it > > updated, and add necessary TRACE_DEFINE_ENUM. > > > > Signed-off-by: Darrick J. Wong > > ... > > > diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h > > index 3f57002ca660..94e289aca220 100644 > > --- a/fs/xfs/xfs_trace.h > > +++ b/fs/xfs/xfs_trace.h > > @@ -1901,11 +1901,11 @@ TRACE_EVENT(xfs_dir2_leafn_moveents, > > { 0, "target" }, \ > > { 1, "temp" } > > ^^^^ that context makes me wonder if we shouldn't move that #define > as well, and give 0 & 1 some meaningful macro names. Patch 7/6? :) Or just combine them into a single tracepoint that emits both inodes. --D > -Eric