From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/6] xfs: stringify btree cursor types in ftrace output
Date: Tue, 18 Dec 2018 10:35:55 -0800 [thread overview]
Message-ID: <20181218183555.GD27208@magnolia> (raw)
In-Reply-To: <e5a62cf6-baac-7652-dd5e-4e1cb1793030@sandeen.net>
On Tue, Dec 18, 2018 at 11:27:42AM -0600, Eric Sandeen wrote:
> On 11/28/18 5:29 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Use __print_symbolic to print the btree type in ftrace output.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> Ignore my previous question.
>
> (if scrub's trace file starts duplicating too much of the common trace stuff,
> though, we may want a common include file?)
I wasn't planning to expand any further than the scrub type.
--D
> But for now
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>
> > ---
> > fs/xfs/libxfs/xfs_types.h | 9 +++++++++
> > fs/xfs/scrub/trace.h | 38 ++++++++++++++++++++++++++------------
> > fs/xfs/xfs_trace.h | 12 ++++++++++--
> > 3 files changed, 45 insertions(+), 14 deletions(-)
> >
> >
> > diff --git a/fs/xfs/libxfs/xfs_types.h b/fs/xfs/libxfs/xfs_types.h
> > index 297cf2318f83..eb04afe9cce0 100644
> > --- a/fs/xfs/libxfs/xfs_types.h
> > +++ b/fs/xfs/libxfs/xfs_types.h
> > @@ -114,6 +114,15 @@ typedef enum {
> > XFS_BTNUM_INOi, XFS_BTNUM_FINOi, XFS_BTNUM_REFCi, XFS_BTNUM_MAX
> > } xfs_btnum_t;
> >
> > +#define XFS_BTNUM_STRINGS \
> > + { XFS_BTNUM_BNOi, "bnobt" }, \
> > + { XFS_BTNUM_CNTi, "cntbt" }, \
> > + { XFS_BTNUM_RMAPi, "rmapbt" }, \
> > + { XFS_BTNUM_BMAPi, "bmbt" }, \
> > + { XFS_BTNUM_INOi, "inobt" }, \
> > + { XFS_BTNUM_FINOi, "finobt" }, \
> > + { XFS_BTNUM_REFCi, "refcbt" }
> > +
> > struct xfs_name {
> > const unsigned char *name;
> > int len;
> > diff --git a/fs/xfs/scrub/trace.h b/fs/xfs/scrub/trace.h
> > index d67e915cf91a..0141eb1ac091 100644
> > --- a/fs/xfs/scrub/trace.h
> > +++ b/fs/xfs/scrub/trace.h
> > @@ -12,6 +12,20 @@
> > #include <linux/tracepoint.h>
> > #include "xfs_bit.h"
> >
> > +/*
> > + * ftrace's __print_symbolic requires that all enum values be wrapped in the
> > + * TRACE_DEFINE_ENUM macro so that the enum value can be encoded in the ftrace
> > + * ring buffer. Somehow this was only worth mentioning in the ftrace sample
> > + * code.
> > + */
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_BNOi);
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_CNTi);
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_BMAPi);
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_INOi);
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_FINOi);
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_RMAPi);
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_REFCi);
> > +
> > DECLARE_EVENT_CLASS(xchk_class,
> > TP_PROTO(struct xfs_inode *ip, struct xfs_scrub_metadata *sm,
> > int error),
> > @@ -278,10 +292,10 @@ TRACE_EVENT(xchk_btree_op_error,
> > __entry->error = error;
> > __entry->ret_ip = ret_ip;
> > ),
> > - TP_printk("dev %d:%d type %u btnum %d level %d ptr %d agno %u agbno %u error %d ret_ip %pS",
> > + TP_printk("dev %d:%d type %u btree %s level %d ptr %d agno %u agbno %u error %d ret_ip %pS",
> > MAJOR(__entry->dev), MINOR(__entry->dev),
> > __entry->type,
> > - __entry->btnum,
> > + __print_symbolic(__entry->btnum, XFS_BTNUM_STRINGS),
> > __entry->level,
> > __entry->ptr,
> > __entry->agno,
> > @@ -321,12 +335,12 @@ TRACE_EVENT(xchk_ifork_btree_op_error,
> > __entry->error = error;
> > __entry->ret_ip = ret_ip;
> > ),
> > - TP_printk("dev %d:%d ino 0x%llx fork %d type %u btnum %d level %d ptr %d agno %u agbno %u error %d ret_ip %pS",
> > + TP_printk("dev %d:%d ino 0x%llx fork %d type %u btree %s level %d ptr %d agno %u agbno %u error %d ret_ip %pS",
> > MAJOR(__entry->dev), MINOR(__entry->dev),
> > __entry->ino,
> > __entry->whichfork,
> > __entry->type,
> > - __entry->btnum,
> > + __print_symbolic(__entry->btnum, XFS_BTNUM_STRINGS),
> > __entry->level,
> > __entry->ptr,
> > __entry->agno,
> > @@ -360,10 +374,10 @@ TRACE_EVENT(xchk_btree_error,
> > __entry->ptr = cur->bc_ptrs[level];
> > __entry->ret_ip = ret_ip;
> > ),
> > - TP_printk("dev %d:%d type %u btnum %d level %d ptr %d agno %u agbno %u ret_ip %pS",
> > + TP_printk("dev %d:%d type %u btree %s level %d ptr %d agno %u agbno %u ret_ip %pS",
> > MAJOR(__entry->dev), MINOR(__entry->dev),
> > __entry->type,
> > - __entry->btnum,
> > + __print_symbolic(__entry->btnum, XFS_BTNUM_STRINGS),
> > __entry->level,
> > __entry->ptr,
> > __entry->agno,
> > @@ -400,12 +414,12 @@ TRACE_EVENT(xchk_ifork_btree_error,
> > __entry->ptr = cur->bc_ptrs[level];
> > __entry->ret_ip = ret_ip;
> > ),
> > - TP_printk("dev %d:%d ino 0x%llx fork %d type %u btnum %d level %d ptr %d agno %u agbno %u ret_ip %pS",
> > + TP_printk("dev %d:%d ino 0x%llx fork %d type %u btree %s level %d ptr %d agno %u agbno %u ret_ip %pS",
> > MAJOR(__entry->dev), MINOR(__entry->dev),
> > __entry->ino,
> > __entry->whichfork,
> > __entry->type,
> > - __entry->btnum,
> > + __print_symbolic(__entry->btnum, XFS_BTNUM_STRINGS),
> > __entry->level,
> > __entry->ptr,
> > __entry->agno,
> > @@ -439,10 +453,10 @@ DECLARE_EVENT_CLASS(xchk_sbtree_class,
> > __entry->nlevels = cur->bc_nlevels;
> > __entry->ptr = cur->bc_ptrs[level];
> > ),
> > - TP_printk("dev %d:%d type %u btnum %d agno %u agbno %u level %d nlevels %d ptr %d",
> > + TP_printk("dev %d:%d type %u btree %s agno %u agbno %u level %d nlevels %d ptr %d",
> > MAJOR(__entry->dev), MINOR(__entry->dev),
> > __entry->type,
> > - __entry->btnum,
> > + __print_symbolic(__entry->btnum, XFS_BTNUM_STRINGS),
> > __entry->agno,
> > __entry->bno,
> > __entry->level,
> > @@ -643,11 +657,11 @@ TRACE_EVENT(xrep_init_btblock,
> > __entry->agbno = agbno;
> > __entry->btnum = btnum;
> > ),
> > - TP_printk("dev %d:%d agno %u agbno %u btnum %d",
> > + TP_printk("dev %d:%d agno %u agbno %u btree %s",
> > MAJOR(__entry->dev), MINOR(__entry->dev),
> > __entry->agno,
> > __entry->agbno,
> > - __entry->btnum)
> > + __print_symbolic(__entry->btnum, XFS_BTNUM_STRINGS))
> > )
> > TRACE_EVENT(xrep_findroot_block,
> > TP_PROTO(struct xfs_mount *mp, xfs_agnumber_t agno, xfs_agblock_t agbno,
> > diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
> > index 94e289aca220..6fcc893dfc91 100644
> > --- a/fs/xfs/xfs_trace.h
> > +++ b/fs/xfs/xfs_trace.h
> > @@ -2194,6 +2194,14 @@ DEFINE_DISCARD_EVENT(xfs_discard_exclude);
> > DEFINE_DISCARD_EVENT(xfs_discard_busy);
> >
> > /* btree cursor events */
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_BNOi);
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_CNTi);
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_BMAPi);
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_INOi);
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_FINOi);
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_RMAPi);
> > +TRACE_DEFINE_ENUM(XFS_BTNUM_REFCi);
> > +
> > DECLARE_EVENT_CLASS(xfs_btree_cur_class,
> > TP_PROTO(struct xfs_btree_cur *cur, int level, struct xfs_buf *bp),
> > TP_ARGS(cur, level, bp),
> > @@ -2213,9 +2221,9 @@ DECLARE_EVENT_CLASS(xfs_btree_cur_class,
> > __entry->ptr = cur->bc_ptrs[level];
> > __entry->daddr = bp ? bp->b_bn : -1;
> > ),
> > - TP_printk("dev %d:%d btnum %d level %d/%d ptr %d daddr 0x%llx",
> > + TP_printk("dev %d:%d btree %s level %d/%d ptr %d daddr 0x%llx",
> > MAJOR(__entry->dev), MINOR(__entry->dev),
> > - __entry->btnum,
> > + __print_symbolic(__entry->btnum, XFS_BTNUM_STRINGS),
> > __entry->level,
> > __entry->nlevels,
> > __entry->ptr,
> >
next prev parent reply other threads:[~2018-12-18 18:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 23:28 [PATCH 0/6] xfs-5.0: ftrace cleanups Darrick J. Wong
2018-11-28 23:28 ` [PATCH 1/6] xfs: fix symbolic enum printing in ftrace output Darrick J. Wong
2018-12-18 17:14 ` Eric Sandeen
2018-11-28 23:29 ` [PATCH 2/6] xfs: fix function pointer type in ftrace format Darrick J. Wong
2018-12-18 17:16 ` Eric Sandeen
2018-11-28 23:29 ` [PATCH 3/6] xfs: move XFS_AG_BTREE_CMP_FORMAT_STR mappings to libxfs Darrick J. Wong
2018-12-18 17:23 ` Eric Sandeen
2018-11-28 23:29 ` [PATCH 4/6] xfs: move XFS_INODE_FORMAT_STR " Darrick J. Wong
2018-12-18 17:24 ` Eric Sandeen
2018-12-18 18:30 ` Darrick J. Wong
2018-12-18 17:25 ` Eric Sandeen
2018-12-18 18:35 ` Darrick J. Wong
2018-11-28 23:29 ` [PATCH 5/6] xfs: stringify btree cursor types in ftrace output Darrick J. Wong
2018-12-18 17:21 ` Eric Sandeen
2018-12-18 17:27 ` Eric Sandeen
2018-12-18 18:35 ` Darrick J. Wong [this message]
2018-11-28 23:29 ` [PATCH 6/6] xfs: stringify scrub " Darrick J. Wong
2018-12-18 17:30 ` Eric Sandeen
2018-12-18 18:41 ` Darrick J. Wong
2018-12-18 20:31 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2018-12-18 20:39 [PATCH v2 0/6] xfs: ftrace cleanups Darrick J. Wong
2018-12-18 20:39 ` [PATCH 5/6] xfs: stringify btree cursor types in ftrace output Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218183555.GD27208@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox