From: Dave Chinner <david@fromorbit.com>
To: linux-xfs@vger.kernel.org
Subject: Re: reflink status?
Date: Wed, 19 Dec 2018 16:30:00 +1100 [thread overview]
Message-ID: <20181219053000.GA4205@dastard> (raw)
In-Reply-To: <20181218212207.GA27985@teal.hq.k1024.org>
On Tue, Dec 18, 2018 at 10:22:07PM +0100, Iustin Pop wrote:
> Apologies if this information is available somewhere, but a quick scan
> at the list archives failed to clarify things for me.
>
> How production ready is the reflink/clone code?
The XFS code is pretty robust - I've been using it in anger for
filesystem image duplication on my test machines for well over a
year now, so it gets beaten on every day by my test machines...
> I saw a patch series in
> October for 4.19rc-something with many fixes ("fixes for serious
> clone/dedupe problems"), so I guess pre-4.19 kernels are not quite
> recommended yet? Is 4.19 OK for it?
... but the vfs interfaces were not so good. The original APIs were
overly complex and not very well defined or implemented, so there
were lots of little corner cases where things could go very wrong.
IOWs, if you are doing basic stuff like cloning entire files (e.g.
cp --reflink=always) then they work just fine. However, if you have
custom apps that do partial file operations (i.e. use the "range"
part of the API) and/or overwrite parts of existing files using
clones, then there's lots of corner cases where stuff can go wrong.
best advice right now is to use the most recent kernel you can -
4.19 has the worst problems already fixed - and upgrade to 4.20 when
it is released.....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-12-19 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 21:22 reflink status? Iustin Pop
2018-12-19 5:30 ` Dave Chinner [this message]
2018-12-19 21:30 ` Iustin Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219053000.GA4205@dastard \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox