From: Christoph Hellwig <hch@infradead.org>
To: Kangjie Lu <kjlu@umn.edu>
Cc: pakki001@umn.edu, "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: add a check for xfs_trans_commit
Date: Thu, 27 Dec 2018 00:07:29 -0800 [thread overview]
Message-ID: <20181227080728.GA12171@infradead.org> (raw)
In-Reply-To: <20181226060516.75103-1-kjlu@umn.edu>
On Wed, Dec 26, 2018 at 12:05:16AM -0600, Kangjie Lu wrote:
> xfs_trans_commit could fails. The checks issues an error message upon
> its failure.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Please take a close look at what could fail in xfs_trans_commit, and how
those failures are logged inside the implementation.
prev parent reply other threads:[~2018-12-27 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 6:05 [PATCH] xfs: add a check for xfs_trans_commit Kangjie Lu
2018-12-27 8:07 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181227080728.GA12171@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).