From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Kenton Varda <kenton@cloudflare.com>
Cc: Dave Chinner <david@fromorbit.com>,
Ivan Babrou <ivan@cloudflare.com>,
linux-xfs@vger.kernel.org, Shawn Bohrer <sbohrer@cloudflare.com>
Subject: Re: Non-blocking socket stuck for multiple seconds on xfs_reclaim_inodes_ag()
Date: Sat, 29 Dec 2018 11:05:32 -0800 [thread overview]
Message-ID: <20181229190532.GA20475@magnolia> (raw)
In-Reply-To: <CAJouXQndAaybOzbSLRq+Uw7a35YLkUnL5NmRC0qLbV+8QP+vaA@mail.gmail.com>
On Tue, Dec 25, 2018 at 07:16:25PM -0800, Kenton Varda wrote:
> On Tue, Dec 25, 2018 at 3:47 PM Dave Chinner <david@fromorbit.com> wrote:
> > But taking out your frustrations on the people who are trying to fix
> > the problems you are seeing isn't productive. We are only a small
> > team and we can't fix every problem that everyone reports
> > immediately. Some things take time to fix.
>
> I agree. My hope is that explaining our use case helps you make XFS
> better, but you don't owe us anything. It's our problem to solve and
> any help you give us is a favor.
>
> > IOWs, there are relatively few applications that have such a
> > significant dependency on memory reclaim having extremely low
> > latency,
>
> Hmm, I'm confused by this. Isn't low-latency memory allocation is a
> common requirement for any kind of interactive workload? I don't see
> what's unique about our use case in this respect. Any desktop and most
> web servers I would think have similar requirements.
>
> I'm sure there's something about our use case that's unusual, but it
> doesn't seem to me that requiring low-latency memory allocation is
> unique.
>
> Maybe the real thing that's odd about us is that we constantly create
> and delete files at a high rate, and that means we have an excessive
> number of dirty inodes to flush?
>
> > IOWs, we're trying to solve *all* the blocking problems that we know
> > that can occur in inode reclaim so that it all just works for
> > everyone without tweaks being necessary. Yes, this takes longer than
> > just addressing the specific symptom that is causing you problems,
> > but the reality is while fixing things properly takes time to get
> > right, everyone will benefit from it being fixed and not just one or
> > two very specific, latency sensitive workloads.
>
> Great, it's good to hear that this problem is expected to be fixed
> eventually. We can patch our way around it in the meantime.
FWIW I /was/ planning to patchbomb every feature that's sitting around
in my xfs development tree on NYE for everyone's enjoyment^Wreview. ;)
Concretely, those features are:
- Scrub fixes
- The eas(ier) parts of online repair
- Deferred inode inactivation (i.e. the thing you're talking about)
- The hard parts of online repair
- Hoisting inode operations to libxfs
- Metadata inode directory tree
- Reverse mapping for realtime devices
--D
> -Kenton
next prev parent reply other threads:[~2018-12-29 19:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 0:36 Non-blocking socket stuck for multiple seconds on xfs_reclaim_inodes_ag() Ivan Babrou
2018-11-29 2:18 ` Dave Chinner
2018-11-29 14:36 ` Shawn Bohrer
2018-11-29 21:20 ` Dave Chinner
2018-11-29 22:22 ` Ivan Babrou
2018-11-30 2:18 ` Dave Chinner
2018-11-30 3:31 ` Ivan Babrou
2018-11-30 6:49 ` Dave Chinner
2018-11-30 7:45 ` Dave Chinner
2018-12-19 22:15 ` Ivan Babrou
2018-12-21 4:00 ` Kenton Varda
2018-12-25 23:47 ` Dave Chinner
2018-12-26 3:16 ` Kenton Varda
2018-12-29 19:05 ` Darrick J. Wong [this message]
2019-01-01 23:48 ` Dave Chinner
2019-01-02 10:34 ` Arkadiusz Miśkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181229190532.GA20475@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=ivan@cloudflare.com \
--cc=kenton@cloudflare.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sbohrer@cloudflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).