From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfs_db: fix finobt record decoding when sparse inodes enabled
Date: Mon, 31 Dec 2018 11:18:48 -0800 [thread overview]
Message-ID: <20181231191848.GB20475@magnolia> (raw)
From: Darrick J. Wong <darrick.wong@oracle.com>
Use the sparse inobt record field decoder (inobt_spcrc_hfld) to decode
finobt records when sparse inodes are enabled. Otherwise, xfs_db
prints out bogus things like:
recs[1] = [startino,freecount,free]
1:[214720,16429,0xfffffffffff80000]
There can never be 16429 records in an inode btree record; instead it
should print:
recs[1] = [startino,holemask,count,freecount,free]
1:[214720,0,64,45,0xfffffffffff80000]
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
db/type.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/db/type.c b/db/type.c
index d0234c57..f5f65042 100644
--- a/db/type.c
+++ b/db/type.c
@@ -151,7 +151,7 @@ static const typ_t __typtab_spcrc[] = {
{ TYP_SYMLINK, "symlink", handle_struct, symlink_crc_hfld,
&xfs_symlink_buf_ops, XFS_SYMLINK_CRC_OFF },
{ TYP_TEXT, "text", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
- { TYP_FINOBT, "finobt", handle_struct, inobt_crc_hfld,
+ { TYP_FINOBT, "finobt", handle_struct, inobt_spcrc_hfld,
&xfs_inobt_buf_ops, XFS_BTREE_SBLOCK_CRC_OFF },
{ TYP_NONE, NULL }
};
next reply other threads:[~2018-12-31 19:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-31 19:18 Darrick J. Wong [this message]
2019-01-01 23:52 ` [PATCH] xfs_db: fix finobt record decoding when sparse inodes enabled Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181231191848.GB20475@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).