From: Luis Chamberlain <mcgrof@kernel.org>
To: linux-xfs@vger.kernel.org, gregkh@linuxfoundation.org,
Alexander.Levin@microsoft.com
Cc: amir73il@gmail.com, hch@infradead.org,
Carlos Maiolino <cmaiolino@redhat.com>,
Dave Chinner <david@fromorbit.com>,
Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 01/10] xfs: Fix xqmstats offsets in /proc/fs/xfs/xqmstat
Date: Thu, 31 Jan 2019 10:09:10 -0800 [thread overview]
Message-ID: <20190131180919.2500-2-mcgrof@kernel.org> (raw)
In-Reply-To: <20190131180919.2500-1-mcgrof@kernel.org>
From: Carlos Maiolino <cmaiolino@redhat.com>
The addition of FIBT, RMAP and REFCOUNT changed the offsets into
__xfssats structure.
This caused xqmstat_proc_show() to display garbage data via
/proc/fs/xfs/xqmstat, once it relies on the offsets marked via macros.
Fix it.
Fixes: 00f4e4f9 xfs: add rmap btree stats infrastructure
Fixes: aafc3c24 xfs: support the XFS_BTNUM_FINOBT free inode btree type
Fixes: 46eeb521 xfs: introduce refcount btree definitions
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
fs/xfs/xfs_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_stats.c b/fs/xfs/xfs_stats.c
index 4e4423153071..740ac9674848 100644
--- a/fs/xfs/xfs_stats.c
+++ b/fs/xfs/xfs_stats.c
@@ -119,7 +119,7 @@ static int xqmstat_proc_show(struct seq_file *m, void *v)
int j;
seq_printf(m, "qm");
- for (j = XFSSTAT_END_IBT_V2; j < XFSSTAT_END_XQMSTAT; j++)
+ for (j = XFSSTAT_END_REFCOUNT; j < XFSSTAT_END_XQMSTAT; j++)
seq_printf(m, " %u", counter_val(xfsstats.xs_stats, j));
seq_putc(m, '\n');
return 0;
--
2.18.0
next prev parent reply other threads:[~2019-01-31 18:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 18:09 [PATCH 00/10] xfs: stable fixes for v4.19.y Luis Chamberlain
2019-01-31 18:09 ` Luis Chamberlain [this message]
2019-01-31 18:19 ` [PATCH 01/10] xfs: Fix xqmstats offsets in /proc/fs/xfs/xqmstat Greg KH
2019-01-31 18:26 ` Luis Chamberlain
2019-01-31 18:09 ` [PATCH 02/10] xfs: cancel COW blocks before swapext Luis Chamberlain
2019-01-31 18:09 ` [PATCH 03/10] xfs: Fix error code in 'xfs_ioc_getbmap()' Luis Chamberlain
2019-01-31 18:09 ` [PATCH 04/10] xfs: fix overflow in xfs_attr3_leaf_verify Luis Chamberlain
2019-01-31 18:09 ` [PATCH 05/10] xfs: fix shared extent data corruption due to missing cow reservation Luis Chamberlain
2019-01-31 18:09 ` [PATCH 06/10] xfs: fix transient reference count error in xfs_buf_resubmit_failed_buffers Luis Chamberlain
2019-01-31 18:09 ` [PATCH 07/10] xfs: delalloc -> unwritten COW fork allocation can go wrong Luis Chamberlain
2019-01-31 18:09 ` [PATCH 08/10] fs/xfs: fix f_ffree value for statfs when project quota is set Luis Chamberlain
2019-01-31 18:09 ` [PATCH 09/10] xfs: fix PAGE_MASK usage in xfs_free_file_space Luis Chamberlain
2019-01-31 18:09 ` [PATCH 10/10] xfs: fix inverted return from xfs_btree_sblock_verify_crc Luis Chamberlain
2019-01-31 18:20 ` [PATCH 00/10] xfs: stable fixes for v4.19.y Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131180919.2500-2-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=Alexander.Levin@microsoft.com \
--cc=amir73il@gmail.com \
--cc=cmaiolino@redhat.com \
--cc=david@fromorbit.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).