From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH -next] xfs: remove duplicated xfs_defer.h
Date: Thu, 31 Jan 2019 15:24:05 -0800 [thread overview]
Message-ID: <20190131232405.GE5761@magnolia> (raw)
In-Reply-To: <20190117070217.12432-1-yuehaibing@huawei.com>
On Thu, Jan 17, 2019 at 03:02:17PM +0800, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Looks fine to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_trans_bmap.c | 1 -
> fs/xfs/xfs_trans_extfree.c | 1 -
> fs/xfs/xfs_trans_refcount.c | 1 -
> fs/xfs/xfs_trans_rmap.c | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_trans_bmap.c b/fs/xfs/xfs_trans_bmap.c
> index 11cff44..e1c7d55 100644
> --- a/fs/xfs/xfs_trans_bmap.c
> +++ b/fs/xfs/xfs_trans_bmap.c
> @@ -17,7 +17,6 @@
> #include "xfs_alloc.h"
> #include "xfs_bmap.h"
> #include "xfs_inode.h"
> -#include "xfs_defer.h"
>
> /*
> * This routine is called to allocate a "bmap update done"
> diff --git a/fs/xfs/xfs_trans_extfree.c b/fs/xfs/xfs_trans_extfree.c
> index 0710434..8ee7a3f 100644
> --- a/fs/xfs/xfs_trans_extfree.c
> +++ b/fs/xfs/xfs_trans_extfree.c
> @@ -18,7 +18,6 @@
> #include "xfs_alloc.h"
> #include "xfs_bmap.h"
> #include "xfs_trace.h"
> -#include "xfs_defer.h"
>
> /*
> * This routine is called to allocate an "extent free done"
> diff --git a/fs/xfs/xfs_trans_refcount.c b/fs/xfs/xfs_trans_refcount.c
> index 6c947ff..8d73472 100644
> --- a/fs/xfs/xfs_trans_refcount.c
> +++ b/fs/xfs/xfs_trans_refcount.c
> @@ -16,7 +16,6 @@
> #include "xfs_refcount_item.h"
> #include "xfs_alloc.h"
> #include "xfs_refcount.h"
> -#include "xfs_defer.h"
>
> /*
> * This routine is called to allocate a "refcount update done"
> diff --git a/fs/xfs/xfs_trans_rmap.c b/fs/xfs/xfs_trans_rmap.c
> index a428909..5c7936b 100644
> --- a/fs/xfs/xfs_trans_rmap.c
> +++ b/fs/xfs/xfs_trans_rmap.c
> @@ -16,7 +16,6 @@
> #include "xfs_rmap_item.h"
> #include "xfs_alloc.h"
> #include "xfs_rmap.h"
> -#include "xfs_defer.h"
>
> /* Set the map extent flags for this reverse mapping. */
> static void
> --
> 2.7.0
>
>
prev parent reply other threads:[~2019-01-31 23:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 7:02 [PATCH -next] xfs: remove duplicated xfs_defer.h YueHaibing
2019-01-31 23:24 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131232405.GE5761@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox