From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-xfs-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.211]:33338 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725957AbfBAH2V (ORCPT <rfc822;linux-xfs@vger.kernel.org>);
        Fri, 1 Feb 2019 02:28:21 -0500
Date: Fri, 1 Feb 2019 08:28:20 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 01/11] FOLD: improve xfs_bmapi_delalloc
Message-ID: <20190201072820.GA14783@lst.de>
References: <20190131075524.4769-1-hch@lst.de> <20190131075524.4769-2-hch@lst.de> <20190131180957.GC36239@bfoster> <20190201072322.GA14711@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190201072322.GA14711@lst.de>
Sender: linux-xfs-owner@vger.kernel.org
List-ID: <linux-xfs.vger.kernel.org>
List-Id: xfs
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org

On Fri, Feb 01, 2019 at 08:23:22AM +0100, Christoph Hellwig wrote:
> > >  	flags |= XFS_BMAPI_DELALLOC;
> > > -	return xfs_bmapi_write(tp, ip, bno, 1, flags, total, imap, nimaps);
> > > +	error = xfs_bmapi_write(tp, ip, offset_fsb, 1, flags,
> > > +			XFS_EXTENTADD_SPACE_RES(ip->i_mount, XFS_DATA_FORK),
> > 
> > Shouldn't this be whichfork?
> 
> Yeah.

Actually - XFS_EXTENTADD_SPACE_RES expands to XFS_BM_MAXLEVELS, which
indexes into m_bm_maxlevels, which only contains two members, one for
the data and one for the attr fork.  So this should stay a hardcoded
XFS_DATA_FORK.