From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v4 0/8] xfs: fix [f]inobt magic value verification
Date: Thu, 7 Feb 2019 13:40:57 -0500 [thread overview]
Message-ID: <20190207184105.17064-1-bfoster@redhat.com> (raw)
Hi all,
This is v4 of the buffer verifier magic value rework. The only changes
in this version are that patch 1 of v3 has been dropped as it is already
merged and that the magic value asserts that were added to several of
the refactored verifiers are replaced with compile-time magic value
offset checks starting from the top-level structures used in the
associated verifiers.
Brian
v4:
- Dropped set buf ops patch (already merged).
- Replace magic value asserts with build-time magic offset checks.
v3: https://marc.info/?l=linux-xfs&m=154929197225225&w=2
- Fix function declarations to include parameter names.
- Convert allocbt buffer verifier.
v2: https://marc.info/?l=linux-xfs&m=154894958207167&w=2
- Include djwong's ->b_ops patch w/ modifications.
- Added patch to fix up existing cpu endian magic checks, fold in typo
fix.
- Replace static inline magic verifier helper with out of line variant,
kill macro.
- Store on-disk byte order magics in ->b_ops.
- Added patch to refactor common xfs_da3_blkinfo checks.
v1: https://marc.info/?l=linux-xfs&m=154878684317178&w=2
- Remove endian conversion from helper.
- Drop finobt bad magic mitigation patch.
- Additional verifier magic fixups.
- Add verifier name typo fixup.
rfcv2: https://marc.info/?l=linux-xfs&m=154868884311668&w=2
- Split off finobt verifier into separate patch, assign it
appropriately.
- Created helpers for xfs_buf_ops magic value verification.
- Added error mitigation patch for problematic finobt blocks.
rfcv1: https://marc.info/?l=linux-xfs&m=154834528212262&w=2
Brian Foster (8):
xfs: always check magic values in on-disk byte order
xfs: create a separate finobt verifier
xfs: distinguish between inobt and finobt magic values
xfs: split up allocation btree verifier
xfs: distinguish between bnobt and cntbt magic values
xfs: use verifier magic field in dir2 leaf verifiers
xfs: miscellaneous verifier magic value fixups
xfs: factor xfs_da3_blkinfo verification into common helper
fs/xfs/libxfs/xfs_ag.c | 6 +-
fs/xfs/libxfs/xfs_alloc.c | 12 ++--
fs/xfs/libxfs/xfs_alloc_btree.c | 74 ++++++++++-----------
fs/xfs/libxfs/xfs_attr_leaf.c | 21 ++----
fs/xfs/libxfs/xfs_attr_remote.c | 8 ++-
fs/xfs/libxfs/xfs_bmap_btree.c | 13 ++--
fs/xfs/libxfs/xfs_da_btree.c | 49 +++++++++-----
fs/xfs/libxfs/xfs_da_format.h | 3 +
fs/xfs/libxfs/xfs_dir2_block.c | 10 +--
fs/xfs/libxfs/xfs_dir2_data.c | 12 ++--
fs/xfs/libxfs/xfs_dir2_leaf.c | 100 ++++++-----------------------
fs/xfs/libxfs/xfs_dir2_node.c | 10 +--
fs/xfs/libxfs/xfs_ialloc.c | 3 +-
fs/xfs/libxfs/xfs_ialloc_btree.c | 25 +++++---
fs/xfs/libxfs/xfs_inode_buf.c | 2 +-
fs/xfs/libxfs/xfs_refcount_btree.c | 3 +-
fs/xfs/libxfs/xfs_rmap_btree.c | 3 +-
fs/xfs/libxfs/xfs_sb.c | 5 +-
fs/xfs/libxfs/xfs_shared.h | 4 +-
fs/xfs/libxfs/xfs_symlink_remote.c | 3 +-
fs/xfs/scrub/agheader_repair.c | 6 +-
fs/xfs/xfs_buf.c | 19 ++++++
fs/xfs/xfs_buf.h | 2 +
fs/xfs/xfs_log_recover.c | 12 ++--
fs/xfs/xfs_ondisk.h | 17 +++++
25 files changed, 218 insertions(+), 204 deletions(-)
--
2.17.2
next reply other threads:[~2019-02-07 18:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 18:40 Brian Foster [this message]
2019-02-07 18:40 ` [PATCH v4 1/8] xfs: always check magic values in on-disk byte order Brian Foster
2019-02-07 18:55 ` [PATCH 0.5/8] xfs: clarify documentation for the function to reverify buffers Darrick J. Wong
2019-02-07 18:40 ` [PATCH v4 2/8] xfs: create a separate finobt verifier Brian Foster
2019-02-07 18:41 ` [PATCH v4 3/8] xfs: distinguish between inobt and finobt magic values Brian Foster
2019-02-07 18:52 ` Darrick J. Wong
2019-02-07 18:59 ` Brian Foster
2019-02-07 18:41 ` [PATCH v4 4/8] xfs: split up allocation btree verifier Brian Foster
2019-02-07 18:41 ` [PATCH v4 5/8] xfs: distinguish between bnobt and cntbt magic values Brian Foster
2019-02-07 18:41 ` [PATCH v4 6/8] xfs: use verifier magic field in dir2 leaf verifiers Brian Foster
2019-02-07 19:10 ` Darrick J. Wong
2019-02-07 19:37 ` Brian Foster
2019-02-07 20:10 ` [PATCH v4.1] " Brian Foster
2019-02-07 18:41 ` [PATCH v4 7/8] xfs: miscellaneous verifier magic value fixups Brian Foster
2019-02-07 19:13 ` Darrick J. Wong
2019-02-07 19:42 ` Brian Foster
2019-02-07 20:11 ` [PATCH v4.1] " Brian Foster
2019-02-07 18:41 ` [PATCH v4 8/8] xfs: factor xfs_da3_blkinfo verification into common helper Brian Foster
2019-02-07 18:56 ` [PATCH 9/8] xfs: add inode magic to inode verifier Darrick J. Wong
2019-02-07 20:27 ` Brian Foster
2019-02-07 18:56 ` [PATCH 10/8] xfs: add magic numbers to dquot buffer ops Darrick J. Wong
2019-02-07 20:27 ` Brian Foster
2019-02-07 18:57 ` [PATCH 11/8] xfs: use buf ops magic to detect btree block type Darrick J. Wong
2019-02-07 20:27 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207184105.17064-1-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).