From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com ([156.151.31.86]:53018 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728875AbfBNPyT (ORCPT ); Thu, 14 Feb 2019 10:54:19 -0500 Date: Thu, 14 Feb 2019 07:54:10 -0800 From: "Darrick J. Wong" Subject: Re: =?utf-8?B?562U5aSNOiBbUkY=?= =?utf-8?Q?C?= PATCH] ext4: add link file support for {GET,SET}XATTR ioctl Message-ID: <20190214155410.GF32253@magnolia> References: <1548899232-30311-1-git-send-email-wshilong1991@gmail.com> <20190131034106.GJ4205@dastard> <20190131174059.GA10211@magnolia> <20190131204301.GK4205@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Wang Shilong Cc: Dave Chinner , Wang Shilong , "linux-ext4@vger.kernel.org" , "linux-fs@vger.kernel.org" , "linux-xfs@vger.kernel.org" , Andreas Dilger , Li Xi On Thu, Feb 14, 2019 at 08:14:56AM +0000, Wang Shilong wrote: > Hi Dave, Darrick, > > Thanks for good suggestions! > As my understanding, we could modify > > do_fchownat() to change project ID instead of > group id if AT_FCHOWN_PROJID(new flags) passed in. > > Besides that we also need a new flag AT_FCHOWN_PROJ_INHERIT. > to set/clear inherit attributes? That sounds reasonable enough to consider as a formal proposal. > And for Project Get, we might need extend 'struct attr {' > to include project id. Let's add a new STATX_PROJID so that statx() callers can fetch it? Also manpage updates and fstests cases... --D > What do you think? > > Thanks, > Shilong