From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, Brian Foster <bfoster@redhat.com>
Subject: Re: small fixes and optimizations for delalloc and reflink
Date: Thu, 14 Feb 2019 07:57:34 -0800 [thread overview]
Message-ID: <20190214155734.GG32253@magnolia> (raw)
In-Reply-To: <20190214081120.GA11119@lst.de>
On Thu, Feb 14, 2019 at 09:11:20AM +0100, Christoph Hellwig wrote:
> On Wed, Feb 13, 2019 at 07:02:53PM +0100, Christoph Hellwig wrote:
> > On Mon, Feb 11, 2019 at 04:03:37PM -0800, Darrick J. Wong wrote:
> > > I pulled this series in and saw a bunch of new regressions in
> > > generic/127 generic/269 generic/476 generic/521 generic/522 xfs/442 with
> > > quota, rmap, and reflink enabled. The regressions were all the
> > > XFS_WANT_CORRUPTED_GOTO near the top of xfs_rmap_unmap_shared.
> >
> > Quick status update: I managed to reproduce this ones on xfs/442 only
> > yesterday. But as soon as I started bisecting it it disappeared again..
>
> And another full overnight run couldn't report this even once.
>
> How reproducible is the issue for you? Are you sure it never happens
> with the baseline, given that this series really doesn't touch anything
> interacting with the rmap?
Nearly every time, so I'll go digging and report back what I find.
(It's odd, because I didn't see anything obvious in the patches that
would cause this...)
--D
prev parent reply other threads:[~2019-02-14 15:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 12:54 small fixes and optimizations for delalloc and reflink Christoph Hellwig
2019-02-11 12:54 ` [PATCH 01/10] xfs: remove the io_type field from the writeback context and ioend Christoph Hellwig
2019-02-11 12:54 ` [PATCH 02/10] xfs: remove the s_maxbytes checks in xfs_map_blocks Christoph Hellwig
2019-02-11 12:54 ` [PATCH 03/10] xfs: simplify the xfs_bmap_btree_to_extents calling conventions Christoph Hellwig
2019-02-11 12:54 ` [PATCH 04/10] xfs: factor out two helpers from xfs_bmapi_write Christoph Hellwig
2019-02-11 12:54 ` [PATCH 05/10] xfs: split XFS_BMAPI_DELALLOC handling " Christoph Hellwig
2019-02-11 15:21 ` Brian Foster
2019-02-11 12:54 ` [PATCH 06/10] xfs: move transaction handling to xfs_bmapi_convert_delalloc Christoph Hellwig
2019-02-11 15:21 ` Brian Foster
2019-02-14 19:38 ` Darrick J. Wong
2019-02-14 21:39 ` Christoph Hellwig
2019-02-11 12:54 ` [PATCH 07/10] xfs: move stat accounting " Christoph Hellwig
2019-02-11 15:21 ` Brian Foster
2019-02-11 12:54 ` [PATCH 08/10] xfs: move xfs_iomap_write_allocate to xfs_aops.c Christoph Hellwig
2019-02-11 15:22 ` Brian Foster
2019-02-15 6:56 ` Christoph Hellwig
2019-02-11 12:54 ` [PATCH 09/10] xfs: remove the truncate short cut in xfs_map_blocks Christoph Hellwig
2019-02-11 15:22 ` Brian Foster
2019-02-11 12:54 ` [PATCH 10/10] xfs: retry COW fork delalloc conversion when no extent was found Christoph Hellwig
2019-02-11 15:23 ` Brian Foster
2019-02-12 0:03 ` small fixes and optimizations for delalloc and reflink Darrick J. Wong
2019-02-13 18:02 ` Christoph Hellwig
2019-02-14 8:11 ` Christoph Hellwig
2019-02-14 15:57 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214155734.GG32253@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox