From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/3] xfs: reserve blocks for ifree transaction during log recovery
Date: Thu, 14 Feb 2019 07:58:49 -0800 [thread overview]
Message-ID: <20190214155849.GH32253@magnolia> (raw)
In-Reply-To: <20190214081700.GC5961@infradead.org>
On Thu, Feb 14, 2019 at 12:17:00AM -0800, Christoph Hellwig wrote:
> On Wed, Feb 13, 2019 at 12:50:59PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Log recovery frees all the inodes stored in the unlinked list, which can
> > cause expansion of the free inode btree. The ifree code skips block
> > reservations if it thinks there's a per-AG space reservation, but we
> > don't set up the reservation until after log recovery, which means that
> > a finobt expansion blows up in xfs_trans_mod_sb when we exceed the
> > transaction's block reservation.
> >
> > To fix this, we set the "no finobt reservation" flag to true when we
> > create the xfs_mount and only set it to false if we confirm that every
> > AG had enough free space to put aside for the finobt.
> >
> > While we're at it we change the flag name to be clearer about what it
> > actually does.
>
> Looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> But throwing in the field rename makes the patch way bigger and
> not as obvious to understand. Any reason it can't be split into
> a separate patch?
Ok, I'll separate the two.
--D
next prev parent reply other threads:[~2019-02-14 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 20:50 [PATCH 1/3] xfs: don't overflow xattr listent buffer Darrick J. Wong
2019-02-13 20:50 ` [PATCH 2/3] xfs: don't ever put nlink > 0 inodes on the unlinked list Darrick J. Wong
2019-02-14 8:15 ` Christoph Hellwig
2019-02-14 16:03 ` Darrick J. Wong
2019-02-14 21:41 ` Christoph Hellwig
2019-02-13 20:50 ` [PATCH 3/3] xfs: reserve blocks for ifree transaction during log recovery Darrick J. Wong
2019-02-14 8:17 ` Christoph Hellwig
2019-02-14 15:58 ` Darrick J. Wong [this message]
2019-02-13 20:58 ` [PATCH 1/3] xfs: don't overflow xattr listent buffer Darrick J. Wong
2019-06-27 16:12 ` [STABLE 4.19] fixes for xfs memory and fs corruption Amir Goldstein
2019-06-27 17:08 ` Darrick J. Wong
2019-06-27 23:32 ` Sasha Levin
2019-07-03 2:47 ` Sasha Levin
2019-02-14 8:11 ` [PATCH 1/3] xfs: don't overflow xattr listent buffer Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214155849.GH32253@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox