From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: don't ever put nlink > 0 inodes on the unlinked list
Date: Thu, 14 Feb 2019 13:41:35 -0800 [thread overview]
Message-ID: <20190214214135.GA9152@infradead.org> (raw)
In-Reply-To: <155009105350.32028.13101526675073908023.stgit@magnolia>
On Wed, Feb 13, 2019 at 12:50:53PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> When XFS creates an O_TMPFILE file, the inode is created with nlink = 1,
> put on the unlinked list, and then the VFS sets nlink = 0 in d_tmpfile.
> If we crash before anything logs the inode (it's dirty incore but the
> vfs doesn't tell us it's dirty so we never log that change), the iunlink
> processing part of recovery will then explode with a pile of:
>
> XFS: Assertion failed: VFS_I(ip)->i_nlink == 0, file:
> fs/xfs/xfs_log_recover.c, line: 5072
>
> Worse yet, since nlink is nonzero, the inodes also don't get cleaned up
> and they just leak until the next xfs_repair run.
>
> Therefore, change xfs_iunlink to require that inodes being put on the
> unlinked list have nlink == 0, change the tmpfile callers to instantiate
> nodes that way, and set the nlink to 1 just prior to calling d_tmpfile.
> Fix the comment for xfs_iunlink while we're at it.
Looks good for a quick fix, even if I think we should fix it different
in the long term:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-02-14 21:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 20:50 [PATCH 1/3] xfs: don't overflow xattr listent buffer Darrick J. Wong
2019-02-13 20:50 ` [PATCH 2/3] xfs: don't ever put nlink > 0 inodes on the unlinked list Darrick J. Wong
2019-02-14 8:15 ` Christoph Hellwig
2019-02-14 16:03 ` Darrick J. Wong
2019-02-14 21:41 ` Christoph Hellwig [this message]
2019-02-13 20:50 ` [PATCH 3/3] xfs: reserve blocks for ifree transaction during log recovery Darrick J. Wong
2019-02-14 8:17 ` Christoph Hellwig
2019-02-14 15:58 ` Darrick J. Wong
2019-02-13 20:58 ` [PATCH 1/3] xfs: don't overflow xattr listent buffer Darrick J. Wong
2019-06-27 16:12 ` [STABLE 4.19] fixes for xfs memory and fs corruption Amir Goldstein
2019-06-27 17:08 ` Darrick J. Wong
2019-06-27 23:32 ` Sasha Levin
2019-07-03 2:47 ` Sasha Levin
2019-02-14 8:11 ` [PATCH 1/3] xfs: don't overflow xattr listent buffer Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214214135.GA9152@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox