Re: [PATCH 1/3] xfs: don't overflow xattr listent buffer

Darrick J. Wong
2019-02-13T20:58:07Z

Bah, I forgot to send the cover letter. Oh well.

xfs: various fixes

The first patch fixes a memory corruption that syzkaller found in the
attr listent code; see "generic: posix acl extended attribute memory
corruption test" for the relevant regression test.

Patches 2 fixes problems found in XFS's unlinked inode recovery code
that were unearthed by some new testcases. We're logging nlink==1 temp
files on the iunlinked list (and then the vfs sets nlink to 0 without
telling us) which means that we leak them in recovery if we crash
immediately after the committing the creation of the temp file.

Patch 3 fixes the problem that ifree during recovery can expand the
finobt but we need to force the ifree code to reserve blocks for the
transaction because perag reservations aren't set up yet.

See "[PATCH v2 2/2] generic: check the behavior of programs opening a
lot of O_TMPFILE files" for the regression test.

--D