Re: [PATCH] xfs: test mkfs extent size hint validation

Dave Chinner
2019-02-18T21:17:49Z

On Mon, Feb 18, 2019 at 10:03:34AM -0800, Darrick J. Wong wrote:
> On Mon, Feb 18, 2019 at 09:07:16AM +1100, Dave Chinner wrote:
> > On Fri, Feb 15, 2019 at 04:41:19PM -0800, Darrick J. Wong wrote:
> > > From: Darrick J. Wong <darrick.wong@oracle.com>
> > >
> > > Make sure mkfs won't format filesystems that fail extent size hint
> > > validation.
> > >
> > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > > ---
> > > tests/xfs/738 | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> > > tests/xfs/738.out | 2 ++
> > > tests/xfs/group | 1 +
> > > 3 files changed, 51 insertions(+)
> > > create mode 100755 tests/xfs/738
> > > create mode 100644 tests/xfs/738.out
> > >
> > > diff --git a/tests/xfs/738 b/tests/xfs/738
> > > new file mode 100755
> > > index 00000000..ee0ffaae
> > > --- /dev/null
> > > +++ b/tests/xfs/738
> > > @@ -0,0 +1,48 @@
> > > +#! /bin/bash
> > > +# SPDX-License-Identifier: GPL-2.0+
> > > +# Copyright (c) 2019 Oracle, Inc. All Rights Reserved.
> > > +#
> > > +# FS QA Test No. 738
> > > +#
> > > +# Make sure we can't format a filesystem with insane extent hints.
> > > +#
> > > +seq=`basename $0`
> > > +seqres=$RESULT_DIR/$seq
> > > +echo "QA output created by $seq"
> > > +tmp=/tmp/$$
> > > +status=1 # failure is the default!
> > > +testfile=$TEST_DIR/$seq.txt
> > > +trap "_cleanup; exit \$status" 0 1 2 3 15
> > > +
> > > +_cleanup()
> > > +{
> > > + cd /
> > > + rm -f $tmp.*
> > > +}
> > > +
> > > +# get standard environment, filters and checks
> > > +. ./common/rc
> > > +
> > > +# real QA test starts here
> > > +_supported_fs xfs
> > > +_supported_os Linux
> > > +_require_scratch_nocheck
> > > +
> > > +rm -f $seqres.full
> > > +
> > > +# Try regular extent size hint
> > > +echo extszinherit >> $seqres.full
> > > +_scratch_mkfs -d extszinherit=8388608 >> $seqres.full 2>&1
> > > +test $? -eq 1 || echo "should have failed extszinherit"
> >
> > That won't fail on 64k block size filesystems....
>
> The extzinherit parameter is copied directly into the root inode without
> any unit conversion (dopts[D_EXTSZINHERIT].convert == false), which
> means that it's specified in units of fs blocks, right? So then the
> only constraints are that the value < MAXEXTLEN and value < agsize/2,
> which means that block size shouldn't matter.

Ah, good point. I read it as 8GB, not 8M blocks.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com