From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2130.oracle.com ([141.146.126.79]:33190 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728234AbfCAPjs (ORCPT ); Fri, 1 Mar 2019 10:39:48 -0500 Date: Fri, 1 Mar 2019 07:39:31 -0800 From: "Darrick J. Wong" Subject: Re: [PATCH 8/8] xfs: support project in xfs_getattr() Message-ID: <20190301153931.GM21626@magnolia> References: <1551449141-7884-1-git-send-email-wshilong1991@gmail.com> <1551449141-7884-9-git-send-email-wshilong1991@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1551449141-7884-9-git-send-email-wshilong1991@gmail.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Wang Shilong Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, lixi@ddn.com, adilger@dilger.ca, Wang Shilong On Fri, Mar 01, 2019 at 11:05:41PM +0900, Wang Shilong wrote: > From: Wang Shilong > > From: Wang Shilong > > Signed-off-by: Wang Shilong > --- > fs/xfs/xfs_iops.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index c10466fe6ed4..a2f8c0f048cf 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -501,6 +501,7 @@ xfs_vn_getattr( > if (XFS_FORCED_SHUTDOWN(mp)) > return -EIO; > > + stat->projid = xfs_projid_to_kprojid(xfs_get_projid(ip)); I think we're supposed to set STATX_PROJID in the result mask if the caller asks for it, right? if (request_mask & STATX_PROJID) { stat->projid = xfs_projid_to_kprojid(xfs_get_projid(ip)); stat->result_mask |= STATX_PROJID; } > stat->size = XFS_ISIZE(ip); > stat->dev = inode->i_sb->s_dev; > stat->mode = inode->i_mode; > @@ -528,6 +529,8 @@ xfs_vn_getattr( > stat->attributes |= STATX_ATTR_APPEND; > if (ip->i_d.di_flags & XFS_DIFLAG_NODUMP) > stat->attributes |= STATX_ATTR_NODUMP; > + if (ip->i_d.di_flags & XFS_DIFLAG_PROJINHERIT) > + stat->attributes |= STATX_ATTR_PROJINHERIT; I think we also have to set STATX_ATTR_PROJINHERIT in the attributes_mask, but ... heh, XFS doesn't do that at all. :( --D > switch (inode->i_mode & S_IFMT) { > case S_IFBLK: > -- > 2.19.1 >