From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: set attributes_mask in xfs_vn_getattr
Date: Fri, 1 Mar 2019 08:56:42 -0800 [thread overview]
Message-ID: <20190301165642.GR21626@magnolia> (raw)
In-Reply-To: <20190301161727.GP21626@magnolia>
On Fri, Mar 01, 2019 at 08:17:27AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> According to the statx documentation we're supposed to set a bit in
> attributes_mask for every inode flag that the filesystem can support.
> We don't, so fix this.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Heh, self-NAK, Luis posted the same thing a year and a half ago...
> ---
> fs/xfs/xfs_iops.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index 1efef69a7f1c..74047bd0c1ae 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -531,6 +531,10 @@ xfs_vn_getattr(
> }
> }
>
> + /*
> + * Note: If you add another clause to set an attribute flag, please
> + * update attributes_mask below.
> + */
...so I'll add this comment to his patch and merge it. Will post
xfsprogs changes and testcase soon.
--D
> if (ip->i_d.di_flags & XFS_DIFLAG_IMMUTABLE)
> stat->attributes |= STATX_ATTR_IMMUTABLE;
> if (ip->i_d.di_flags & XFS_DIFLAG_APPEND)
> @@ -538,6 +542,10 @@ xfs_vn_getattr(
> if (ip->i_d.di_flags & XFS_DIFLAG_NODUMP)
> stat->attributes |= STATX_ATTR_NODUMP;
>
> + stat->attributes_mask |= (STATX_ATTR_IMMUTABLE |
> + STATX_ATTR_APPEND |
> + STATX_ATTR_NODUMP);
> +
> switch (inode->i_mode & S_IFMT) {
> case S_IFBLK:
> case S_IFCHR:
prev parent reply other threads:[~2019-03-01 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 16:17 [PATCH] xfs: set attributes_mask in xfs_vn_getattr Darrick J. Wong
2019-03-01 16:56 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301165642.GR21626@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox