From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com ([156.151.31.86]:43464 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388860AbfCAQ4q (ORCPT ); Fri, 1 Mar 2019 11:56:46 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x21Gs2Ng019044 for ; Fri, 1 Mar 2019 16:56:44 GMT Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2qtwkurg51-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 01 Mar 2019 16:56:44 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x21Guh0X020331 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 1 Mar 2019 16:56:43 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x21Guhjv024185 for ; Fri, 1 Mar 2019 16:56:43 GMT Date: Fri, 1 Mar 2019 08:56:42 -0800 From: "Darrick J. Wong" Subject: Re: [PATCH] xfs: set attributes_mask in xfs_vn_getattr Message-ID: <20190301165642.GR21626@magnolia> References: <20190301161727.GP21626@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190301161727.GP21626@magnolia> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: xfs On Fri, Mar 01, 2019 at 08:17:27AM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > According to the statx documentation we're supposed to set a bit in > attributes_mask for every inode flag that the filesystem can support. > We don't, so fix this. > > Signed-off-by: Darrick J. Wong Heh, self-NAK, Luis posted the same thing a year and a half ago... > --- > fs/xfs/xfs_iops.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index 1efef69a7f1c..74047bd0c1ae 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -531,6 +531,10 @@ xfs_vn_getattr( > } > } > > + /* > + * Note: If you add another clause to set an attribute flag, please > + * update attributes_mask below. > + */ ...so I'll add this comment to his patch and merge it. Will post xfsprogs changes and testcase soon. --D > if (ip->i_d.di_flags & XFS_DIFLAG_IMMUTABLE) > stat->attributes |= STATX_ATTR_IMMUTABLE; > if (ip->i_d.di_flags & XFS_DIFLAG_APPEND) > @@ -538,6 +542,10 @@ xfs_vn_getattr( > if (ip->i_d.di_flags & XFS_DIFLAG_NODUMP) > stat->attributes |= STATX_ATTR_NODUMP; > > + stat->attributes_mask |= (STATX_ATTR_IMMUTABLE | > + STATX_ATTR_APPEND | > + STATX_ATTR_NODUMP); > + > switch (inode->i_mode & S_IFMT) { > case S_IFBLK: > case S_IFCHR: