* [PATCH] scrub: fix typo in unicrash header file
@ 2019-04-04 17:24 Eric Sandeen
2019-04-04 18:01 ` Darrick J. Wong
2019-04-04 18:06 ` Bill O'Donnell
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2019-04-04 17:24 UTC (permalink / raw)
To: linux-xfs
The no-op #definintion was missing 'fs_' so remained undefined
in the #else case.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/scrub/unicrash.h b/scrub/unicrash.h
index 85fcabc..fb8f5f7 100644
--- a/scrub/unicrash.h
+++ b/scrub/unicrash.h
@@ -28,7 +28,7 @@ bool unicrash_check_fs_label(struct unicrash *uc, const char *descr,
#else
# define unicrash_dir_init(u, c, b) (true)
# define unicrash_xattr_init(u, c, b) (true)
-# define unicrash_label_init(u, c) (true)
+# define unicrash_fs_label_init(u, c) (true)
# define unicrash_free(u) do {(u) = (u);} while (0)
# define unicrash_check_dir_name(u, d, n) (true)
# define unicrash_check_xattr_name(u, d, n) (true)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scrub: fix typo in unicrash header file
2019-04-04 17:24 [PATCH] scrub: fix typo in unicrash header file Eric Sandeen
@ 2019-04-04 18:01 ` Darrick J. Wong
2019-04-04 18:06 ` Bill O'Donnell
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2019-04-04 18:01 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Thu, Apr 04, 2019 at 12:24:40PM -0500, Eric Sandeen wrote:
> The no-op #definintion was missing 'fs_' so remained undefined
> in the #else case.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
LGTM,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/scrub/unicrash.h b/scrub/unicrash.h
> index 85fcabc..fb8f5f7 100644
> --- a/scrub/unicrash.h
> +++ b/scrub/unicrash.h
> @@ -28,7 +28,7 @@ bool unicrash_check_fs_label(struct unicrash *uc, const char *descr,
> #else
> # define unicrash_dir_init(u, c, b) (true)
> # define unicrash_xattr_init(u, c, b) (true)
> -# define unicrash_label_init(u, c) (true)
> +# define unicrash_fs_label_init(u, c) (true)
> # define unicrash_free(u) do {(u) = (u);} while (0)
> # define unicrash_check_dir_name(u, d, n) (true)
> # define unicrash_check_xattr_name(u, d, n) (true)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scrub: fix typo in unicrash header file
2019-04-04 17:24 [PATCH] scrub: fix typo in unicrash header file Eric Sandeen
2019-04-04 18:01 ` Darrick J. Wong
@ 2019-04-04 18:06 ` Bill O'Donnell
1 sibling, 0 replies; 3+ messages in thread
From: Bill O'Donnell @ 2019-04-04 18:06 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Thu, Apr 04, 2019 at 12:24:40PM -0500, Eric Sandeen wrote:
> The no-op #definintion was missing 'fs_' so remained undefined
> in the #else case.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Looks good.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
>
> diff --git a/scrub/unicrash.h b/scrub/unicrash.h
> index 85fcabc..fb8f5f7 100644
> --- a/scrub/unicrash.h
> +++ b/scrub/unicrash.h
> @@ -28,7 +28,7 @@ bool unicrash_check_fs_label(struct unicrash *uc, const char *descr,
> #else
> # define unicrash_dir_init(u, c, b) (true)
> # define unicrash_xattr_init(u, c, b) (true)
> -# define unicrash_label_init(u, c) (true)
> +# define unicrash_fs_label_init(u, c) (true)
> # define unicrash_free(u) do {(u) = (u);} while (0)
> # define unicrash_check_dir_name(u, d, n) (true)
> # define unicrash_check_xattr_name(u, d, n) (true)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-04 18:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-04 17:24 [PATCH] scrub: fix typo in unicrash header file Eric Sandeen
2019-04-04 18:01 ` Darrick J. Wong
2019-04-04 18:06 ` Bill O'Donnell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox