From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: remove unused m_data_workqueue
Date: Mon, 15 Apr 2019 10:49:39 -0400 [thread overview]
Message-ID: <20190415144936.GB4222@bfoster> (raw)
In-Reply-To: <155529407512.243484.4836699205659210299.stgit@magnolia>
On Sun, Apr 14, 2019 at 07:07:55PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Now that we're no longer using m_data_workqueue, remove it.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_mount.h | 1 -
> fs/xfs/xfs_super.c | 10 +---------
> 2 files changed, 1 insertion(+), 10 deletions(-)
>
>
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index 110f927cf943..1d3a4b2bdc2f 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -175,7 +175,6 @@ typedef struct xfs_mount {
> struct xstats m_stats; /* per-fs stats */
>
> struct workqueue_struct *m_buf_workqueue;
> - struct workqueue_struct *m_data_workqueue;
> struct workqueue_struct *m_unwritten_workqueue;
> struct workqueue_struct *m_cil_workqueue;
> struct workqueue_struct *m_reclaim_workqueue;
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index f093ea244849..df917f41ca46 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -838,15 +838,10 @@ xfs_init_mount_workqueues(
> if (!mp->m_buf_workqueue)
> goto out;
>
> - mp->m_data_workqueue = alloc_workqueue("xfs-data/%s",
> - WQ_MEM_RECLAIM|WQ_FREEZABLE, 0, mp->m_fsname);
> - if (!mp->m_data_workqueue)
> - goto out_destroy_buf;
> -
> mp->m_unwritten_workqueue = alloc_workqueue("xfs-conv/%s",
> WQ_MEM_RECLAIM|WQ_FREEZABLE, 0, mp->m_fsname);
> if (!mp->m_unwritten_workqueue)
> - goto out_destroy_data_iodone_queue;
> + goto out_destroy_buf;
>
> mp->m_cil_workqueue = alloc_workqueue("xfs-cil/%s",
> WQ_MEM_RECLAIM|WQ_FREEZABLE, 0, mp->m_fsname);
> @@ -886,8 +881,6 @@ xfs_init_mount_workqueues(
> destroy_workqueue(mp->m_cil_workqueue);
> out_destroy_unwritten:
> destroy_workqueue(mp->m_unwritten_workqueue);
> -out_destroy_data_iodone_queue:
> - destroy_workqueue(mp->m_data_workqueue);
> out_destroy_buf:
> destroy_workqueue(mp->m_buf_workqueue);
> out:
> @@ -903,7 +896,6 @@ xfs_destroy_mount_workqueues(
> destroy_workqueue(mp->m_log_workqueue);
> destroy_workqueue(mp->m_reclaim_workqueue);
> destroy_workqueue(mp->m_cil_workqueue);
> - destroy_workqueue(mp->m_data_workqueue);
> destroy_workqueue(mp->m_unwritten_workqueue);
> destroy_workqueue(mp->m_buf_workqueue);
> }
>
next prev parent reply other threads:[~2019-04-15 14:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 2:07 [PATCH v2 0/3] xfs: merged io completions Darrick J. Wong
2019-04-15 2:07 ` [PATCH 1/3] xfs: implement per-inode writeback completion queues Darrick J. Wong
2019-04-15 14:49 ` Brian Foster
2019-04-15 15:53 ` Darrick J. Wong
2019-04-15 16:13 ` Brian Foster
2019-04-15 17:09 ` Darrick J. Wong
2019-04-15 17:31 ` Brian Foster
2019-04-15 18:00 ` Darrick J. Wong
2019-04-15 18:13 ` Brian Foster
2019-04-15 19:27 ` Darrick J. Wong
2019-04-15 16:13 ` [PATCH v2 " Darrick J. Wong
2019-04-15 18:13 ` Brian Foster
2019-04-23 6:34 ` [PATCH " Christoph Hellwig
2019-04-23 15:29 ` Darrick J. Wong
2019-04-15 2:07 ` [PATCH 2/3] xfs: remove unused m_data_workqueue Darrick J. Wong
2019-04-15 14:49 ` Brian Foster [this message]
2019-04-15 2:08 ` [PATCH 3/3] xfs: merge adjacent io completions of the same type Darrick J. Wong
2019-04-15 14:49 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415144936.GB4222@bfoster \
--to=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox