From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:41574 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727012AbfDPAGu (ORCPT ); Mon, 15 Apr 2019 20:06:50 -0400 Date: Tue, 16 Apr 2019 08:06:33 +0800 From: Ming Lei Subject: Re: [PATCH] nvme/012 & 013: avoid extremely slow xfs IO Message-ID: <20190416000632.GA670@ming.t460p> References: <20190415012229.20689-1-ming.lei@redhat.com> <57a5b163-5d7a-d5a0-fe9a-614b1d638472@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57a5b163-5d7a-d5a0-fe9a-614b1d638472@redhat.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: sandeen@redhat.com Cc: Chaitanya Kulkarni , Omar Sandoval , "linux-block@vger.kernel.org" , Dave Chinner , "Darrick J. Wong" , "linux-xfs@vger.kernel.org" On Mon, Apr 15, 2019 at 09:46:02AM -0400, Eric Sandeen wrote: > On 4/14/19 9:01 PM, Chaitanya Kulkarni wrote: > > Thanks for the patch Ming. Couple of comments below. > > On 4/14/19 6:22 PM, Ming Lei wrote: > >> It is observed that nvme/012 may take ~17 minutes to complete on aarch64, > >> even worse it may trigger IO timeout on nvme-loop. > >> > >> Eric and Dave replied that it is because of too small log size on small > >> disk. > >> > >> So pass '-l size=32m' to avoid the issue. > >> > >> With this patch, nvme/012 can be completed in one minute. > >> > > Then we should set the QUICK=1 if its taking shorter time. > > > >> Cc: Eric Sandeen > >> Cc: Dave Chinner > >> Cc: "Darrick J. Wong" > >> Cc: linux-xfs@vger.kernel.org > >> Signed-off-by: Ming Lei > >> --- > >> tests/nvme/012 | 2 +- > >> tests/nvme/013 | 2 +- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/tests/nvme/012 b/tests/nvme/012 > >> index 9a6801511df7..d7a8751ec752 100755 > >> --- a/tests/nvme/012 > >> +++ b/tests/nvme/012 > >> @@ -46,7 +46,7 @@ test() { > >> > >> umount ${mount_dir} > /dev/null 2>&1 > >> > >> - mkfs.xfs -f /dev/"${nvmedev}n1" > /dev/null 2>&1 > >> + mkfs.xfs -l size=32m -f /dev/"${nvmedev}n1" > /dev/null 2>&1 > >> > > As a part of this series lets move this to the helper mkfs in the > > nvme/rc and use that call in all the file-backed ns related testcases. > > Let me know if you want me to do that or you would like to do that as a > > part of this series. I'm okay with anything. > > We also discussed making the log size larger by default, on small fielsystems, > but that won't help you yet. > > My only caution is that manually setting the log to 32m may actually create > a smaller than default log if your backing file happens to be very large. > Just something to consider. If the backing files are typically around the > 4G size of this test (?) then 32m seems reasonable, 128m certainly would > not hurt. In the two tests, the device size is 1G, and looks 32m log size works just fine. thanks, Ming