From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, Brian Foster <bfoster@redhat.com>
Subject: Re: [PATCH 1/5] xfs: refactor scrub context initialization
Date: Tue, 16 Apr 2019 10:47:02 +1000 [thread overview]
Message-ID: <20190416004702.GG29573@dread.disaster.area> (raw)
In-Reply-To: <155537397718.27935.17999873230143153206.stgit@magnolia>
On Mon, Apr 15, 2019 at 05:19:37PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> It's a little silly how the memset in scrub context initialization
> forces us to declare stack variables to preserve context variables
> across a retry. Since the teardown functions already null out most of
> the ephemeral state (buffer pointers, btree cursors, etc.), just skip
> the memset and move the initialization as needed.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks sane
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-04-16 0:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 0:19 [PATCH v3 0/5] xfs: scrub/repair update health tracking Darrick J. Wong
2019-04-16 0:19 ` [PATCH 1/5] xfs: refactor scrub context initialization Darrick J. Wong
2019-04-16 0:47 ` Dave Chinner [this message]
2019-04-16 0:19 ` [PATCH 2/5] xfs: collapse scrub bool state flags into a single unsigned int Darrick J. Wong
2019-04-16 0:49 ` Dave Chinner
2019-04-16 0:19 ` [PATCH 3/5] xfs: hoist the already_fixed variable to the scrub context Darrick J. Wong
2019-04-16 0:51 ` Dave Chinner
2019-04-16 0:54 ` Darrick J. Wong
2019-04-16 0:19 ` [PATCH 4/5] xfs: scrub/repair should update filesystem metadata health Darrick J. Wong
2019-04-16 1:09 ` Dave Chinner
2019-04-16 1:31 ` Darrick J. Wong
2019-04-16 1:43 ` [PATCH v2 " Darrick J. Wong
2019-04-16 7:57 ` Dave Chinner
2019-04-16 0:20 ` [PATCH 5/5] xfs: scrub should only cross-reference with healthy btrees Darrick J. Wong
2019-04-16 1:16 ` Dave Chinner
2019-04-16 1:45 ` [PATCH v2 " Darrick J. Wong
2019-04-16 7:58 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416004702.GG29573@dread.disaster.area \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox