From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:53586 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbfDWGWx (ORCPT ); Tue, 23 Apr 2019 02:22:53 -0400 Date: Mon, 22 Apr 2019 23:22:52 -0700 From: Christoph Hellwig Subject: Re: [PATCH] xfs: abort unaligned nowait directio early Message-ID: <20190423062252.GD28518@infradead.org> References: <20190417144006.GH114154@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190417144006.GH114154@magnolia> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: "Darrick J. Wong" Cc: xfs , Brian Foster , Dave Chinner On Wed, Apr 17, 2019 at 07:40:06AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Dave Chinner noticed that xfs_file_dio_aio_write returns EAGAIN without > dropping the IOLOCK when its deciding not to wait, which means that we > leak the IOLOCK there. Since we now make unaligned directio always > wait, we have the opportunity to bail out before trying to take the > lock, which should reduce the overhead of this never-gonna-work case > considerably while also solving the dropped lock problem. > > Reported-by: Dave Chinner > Signed-off-by: Darrick J. Wong Looks good, Reviewed-by: Christoph Hellwig