From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Brian Foster <bfoster@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: make tr_growdata a permanent transaction
Date: Mon, 22 Apr 2019 23:24:47 -0700 [thread overview]
Message-ID: <20190423062447.GE28518@infradead.org> (raw)
In-Reply-To: <20190417143759.GG114154@magnolia>
On Wed, Apr 17, 2019 at 07:37:59AM -0700, Darrick J. Wong wrote:
>
> /me wonders if we ought to have a comment here about why we're asserting
> on this? i.e.
> /*
> * This function can shrink the AGFL, which uses a deferred op to avoid
> * exceeding transaction reservation (or whatever the original reason
> * was). Deferred ops require a transaction with a permanent
> * reservation, so check that here.
> */
> ASSERT(...);
Yes, I think we should. Also I think adding this assert should be
a separate commit from the original fix to even more clearly document
the intention.
next prev parent reply other threads:[~2019-04-23 6:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 9:36 [PATCH] xfs: make tr_growdata a permanent transaction Brian Foster
2019-04-17 9:54 ` Brian Foster
2019-04-17 14:34 ` Darrick J. Wong
2019-04-17 14:37 ` Darrick J. Wong
2019-04-17 15:33 ` Brian Foster
2019-04-17 15:47 ` Darrick J. Wong
2019-04-23 6:24 ` Christoph Hellwig [this message]
2019-04-23 15:04 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2019-04-23 15:07 Darrick J. Wong
2019-04-23 15:28 ` Brian Foster
2019-04-23 15:49 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423062447.GE28518@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox