Re: [PATCH] xfs: make tr_growdata a permanent transaction

Christoph Hellwig
2019-04-23T06:24:48Z

On Wed, Apr 17, 2019 at 07:37:59AM -0700, Darrick J. Wong wrote:
>
> /me wonders if we ought to have a comment here about why we're asserting
> on this? i.e.
> /*
> * This function can shrink the AGFL, which uses a deferred op to avoid
> * exceeding transaction reservation (or whatever the original reason
> * was). Deferred ops require a transaction with a permanent
> * reservation, so check that here.
> */
> ASSERT(...);

Yes, I think we should. Also I think adding this assert should be
a separate commit from the original fix to even more clearly document
the intention.