Re: [PATCH] xfs: make tr_growdata a permanent transaction

Darrick J. Wong
2019-04-23T15:05:37Z

On Mon, Apr 22, 2019 at 11:24:47PM -0700, Christoph Hellwig wrote:
> On Wed, Apr 17, 2019 at 07:37:59AM -0700, Darrick J. Wong wrote:
> >
> > /me wonders if we ought to have a comment here about why we're asserting
> > on this? i.e.
> > /*
> > * This function can shrink the AGFL, which uses a deferred op to avoid
> > * exceeding transaction reservation (or whatever the original reason
> > * was). Deferred ops require a transaction with a permanent
> > * reservation, so check that here.
> > */
> > ASSERT(...);
>
> Yes, I think we should. Also I think adding this assert should be
> a separate commit from the original fix to even more clearly document
> the intention.

<shrug> OK. I chatted with Brian and we'll just split the assert into a
new patch... eh, this patch has changed enough I'm going to send both
of them to the list for everyone's perusal. (I'd already added them to
my tree, but having not pushed to for-next it isn't too late to make
more changes.)

--D