public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: implement per-inode writeback completion queues
Date: Mon, 22 Apr 2019 23:34:21 -0700	[thread overview]
Message-ID: <20190423063421.GA6788@infradead.org> (raw)
In-Reply-To: <155529406877.243484.8074329168835632578.stgit@magnolia>

I'm a little late to the game, sorry..

But:

> +
> +	spin_lock_irqsave(&ip->i_iodone_lock, flags);
> +	list_replace_init(&ip->i_iodone_list, &completion_list);
> +	spin_unlock_irqrestore(&ip->i_iodone_lock, flags);

I really don't like this new per-inode lock, and the irq disabling at
all.  Especially as the pattern perfectly fits the lockless lists (llists).
Can you check if these work here?

  parent reply	other threads:[~2019-04-23  6:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15  2:07 [PATCH v2 0/3] xfs: merged io completions Darrick J. Wong
2019-04-15  2:07 ` [PATCH 1/3] xfs: implement per-inode writeback completion queues Darrick J. Wong
2019-04-15 14:49   ` Brian Foster
2019-04-15 15:53     ` Darrick J. Wong
2019-04-15 16:13       ` Brian Foster
2019-04-15 17:09         ` Darrick J. Wong
2019-04-15 17:31           ` Brian Foster
2019-04-15 18:00             ` Darrick J. Wong
2019-04-15 18:13               ` Brian Foster
2019-04-15 19:27                 ` Darrick J. Wong
2019-04-15 16:13   ` [PATCH v2 " Darrick J. Wong
2019-04-15 18:13     ` Brian Foster
2019-04-23  6:34   ` Christoph Hellwig [this message]
2019-04-23 15:29     ` [PATCH " Darrick J. Wong
2019-04-15  2:07 ` [PATCH 2/3] xfs: remove unused m_data_workqueue Darrick J. Wong
2019-04-15 14:49   ` Brian Foster
2019-04-15  2:08 ` [PATCH 3/3] xfs: merge adjacent io completions of the same type Darrick J. Wong
2019-04-15 14:49   ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190423063421.GA6788@infradead.org \
    --to=hch@infradead.org \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox