From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/5] xfs: allow scrubbers to pause background reclaim
Date: Fri, 26 Apr 2019 08:45:04 +1000 [thread overview]
Message-ID: <20190425224504.GD29573@dread.disaster.area> (raw)
In-Reply-To: <155563327720.112668.11514675530007162880.stgit@magnolia>
On Thu, Apr 18, 2019 at 05:21:17PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> The forthcoming summary counter patch races with regular filesystem
> activity to compute rough expected values for the counters. This design
> was chosen to avoid having to freeze the entire filesystem to check the
> counters, but while that's running we'd prefer to minimize background
> reclamation activity to reduce the perturbations to the incore free
> block count. Therefore, provide a way for scrubbers to disable
> background posteof and cowblock reclamation.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
LGTM.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-04-25 22:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 0:20 [PATCH v2 0/5] xfs: scrub filesystem summary counters Darrick J. Wong
2019-04-19 0:21 ` [PATCH 1/5] xfs: track delayed allocation reservations across Darrick J. Wong
2019-04-25 22:43 ` Dave Chinner
2019-04-19 0:21 ` [PATCH 2/5] xfs: rename the speculative block allocation reclaim toggle functions Darrick J. Wong
2019-04-25 22:44 ` Dave Chinner
2019-04-19 0:21 ` [PATCH 3/5] xfs: allow scrubbers to pause background reclaim Darrick J. Wong
2019-04-25 22:45 ` Dave Chinner [this message]
2019-04-19 0:21 ` [PATCH 4/5] xfs: scrub should check incore counters against ondisk headers Darrick J. Wong
2019-04-25 22:46 ` Dave Chinner
2019-04-19 0:21 ` [PATCH 5/5] xfs: add online scrub for superblock counters Darrick J. Wong
2019-04-25 23:30 ` Dave Chinner
2019-04-26 1:32 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425224504.GD29573@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox