From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH V2] xfs: change some error-less functions to void types
Date: Thu, 2 May 2019 09:49:39 +1000 [thread overview]
Message-ID: <20190501234939.GK29573@dread.disaster.area> (raw)
In-Reply-To: <2a52ea5e-e056-244b-4d9b-04ed15d996fd@sandeen.net>
On Wed, May 01, 2019 at 05:20:52PM -0500, Eric Sandeen wrote:
> There are several functions which have no opportunity to retun
return
> an error, and don't contain any ASSERTs which could be argued
> to be better constructed as error cases. So, make them voids
> to simplify the callers.
Does it make the code smaller? :)
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
LGTM.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-05-01 23:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 15:55 [PATCH] xfs: change some error-less functions to void types Eric Sandeen
2019-05-01 22:16 ` Dave Chinner
2019-05-01 22:20 ` [PATCH V2] " Eric Sandeen
2019-05-01 23:49 ` Dave Chinner [this message]
2019-05-02 12:17 ` Brian Foster
2019-05-02 14:44 ` Eric Sandeen
2019-05-02 14:50 ` [PATCH V3] " Eric Sandeen
2019-05-02 14:59 ` [PATCH V4] " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501234939.GK29573@dread.disaster.area \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox