Re: [PATCH V2] xfs: change some error-less functions to void types

Dave Chinner
2019-05-01T23:49:43Z

On Wed, May 01, 2019 at 05:20:52PM -0500, Eric Sandeen wrote:
> There are several functions which have no opportunity to retun
return

> an error, and don't contain any ASSERTs which could be argued
> to be better constructed as error cases. So, make them voids
> to simplify the callers.

Does it make the code smaller? :)

>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

LGTM.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com