Re: xfs: Assertion failed in xfs_ag_resv_init()

Andre Noll
2019-05-01T17:01:01Z

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

On Wed, May 01, 08:36, Darrick J. Wong wrote

> > I guess the important question is how much impact this issue
> > has on production systems (i.e., on CONFIG_XFS_DEBUG=n kernels,
> > where the assert statement is not compiled in). If the unpatched
> > xfs_inobt_max_size() is very unlikely to cause problems on such
> > systems, we might as well live with it.
>
> ...but it's unlikely to cause problems since the allocator will probably
> pass over that runt AG so long as the others have more space and it will
> mostly stay empty.

That makes me feel better, as we have many such systems. Thanks for
the assessment of risks.

> (He says knocking on wood knowing that he's now tempted fate :P)

One reason more to apply the patch :)

Andre
--
Max Planck Institute for Developmental Biology
Max-Planck-Ring 5, 72076 Tübingen, Germany. Phone: (+49) 7071 601 829
http://people.tuebingen.mpg.de/maan/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]