From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>, Dave Chinner <david@fromorbit.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] mkfs: enable reflink and rmap by default
Date: Thu, 2 May 2019 17:57:17 -0700 [thread overview]
Message-ID: <20190503005717.GO5207@magnolia> (raw)
From: Darrick J. Wong <darrick.wong@oracle.com>
Enable reflink and reverse mapping by default.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
mkfs/xfs_mkfs.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 0862621a..3874f7dd 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -2021,14 +2021,14 @@ _("sparse inodes not supported without CRC support\n"));
}
cli->sb_feat.spinodes = false;
- if (cli->sb_feat.rmapbt) {
+ if (cli->sb_feat.rmapbt && cli_opt_set(&mopts, M_RMAPBT)) {
fprintf(stderr,
_("rmapbt not supported without CRC support\n"));
usage();
}
cli->sb_feat.rmapbt = false;
- if (cli->sb_feat.reflink) {
+ if (cli->sb_feat.reflink && cli_opt_set(&mopts, M_REFLINK)) {
fprintf(stderr,
_("reflink not supported without CRC support\n"));
usage();
@@ -3934,8 +3934,8 @@ main(
.dirftype = true,
.finobt = true,
.spinodes = true,
- .rmapbt = false,
- .reflink = false,
+ .rmapbt = true,
+ .reflink = true,
.parent_pointers = false,
.nodalign = false,
.nortalign = false,
next reply other threads:[~2019-05-03 0:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 0:57 Darrick J. Wong [this message]
2019-05-03 15:55 ` [PATCH] mkfs: enable reflink and rmap by default Eric Sandeen
2019-05-03 21:49 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503005717.GO5207@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox