From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:45394 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbfEOHwy (ORCPT ); Wed, 15 May 2019 03:52:54 -0400 Date: Wed, 15 May 2019 00:52:53 -0700 From: Christoph Hellwig Subject: Re: [PATCH 1/6] xfs: refactor small allocation helper to skip cntbt attempt Message-ID: <20190515075253.GG29211@infradead.org> References: <20190509165839.44329-1-bfoster@redhat.com> <20190509165839.44329-2-bfoster@redhat.com> <20190510172446.GA18992@infradead.org> <20190513154433.GD61135@bfoster> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190513154433.GD61135@bfoster> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Brian Foster Cc: Christoph Hellwig , linux-xfs@vger.kernel.org On Mon, May 13, 2019 at 11:44:34AM -0400, Brian Foster wrote: > The only functional change was basically to check for ccur before using > it and initializing i to zero. It just seemed to make sense to clean up > the surrounding code while there, but I can either split out the > aesthetic cleanup or defer that stuff to the broader rework at the end > of the series (where the cursor stuff just gets ripped out anyways) if > either of those is cleaner.. Yeah, I noticed how trivial the actual change was. That is why just doing the cleanup in pass 1 and applying the change in pass 2 might make it more readbale. It might also be worth to throw in the use a goto label instead of long conditionals from your last patch into that cleanup prep patch.